[D7] Hypothesis [#3024761]

Please help me adding hypothesis module under Drupal’s security advisory policy

Project link
https://www.drupal.org/project/hypothesis

Git instructions
git clone --branch 7.x-1.x https://git.drupal.org/project/hypothesis.git

PAReview checklist
https://pareview.sh/pareview/https-git.drupal.org-project-hypothesis.git

Followings are few modules I do maintain,
* Snippet: https://www.drupal.org/project/snippet
* Panels Ajax Tabs: https://www.drupal.org/project/panels_ajax_tab
* Advanced Page: https://www.drupal.org/project/advanced_page
* Stackly: https://www.drupal.org/project/stackly

Is it possible to have permission to add projects under Drupal's security advisory policy?

Comments

Comment #1

9 January 2019 at 14:36

rahul.shinde created an issue. See original summary.

Comment #2

manish34jain CreditAttribution: manish34jain as a volunteer and commented 9 January 2019 at 17:44

Status:

Needs review

» Needs work

Hello Rahul,

Checked and fixed issues using pareview.sh

DrupalPractice has found some issues with your code, but could be false positives.

FILE: ...ite1101/web/vendor/drupal/pareviewsh/pareview_temp/hypothesis.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
 31 | WARNING | Do not use drupal_add_js() in hook_page_build(), use
    |         | #attached for CSS and JS on the $page render array
    |         | instead
 32 | WARNING | Do not use drupal_add_js() in hook_page_build(), use
    |         | #attached for CSS and JS on the $page render array
    |         | instead
 36 | WARNING | Do not use drupal_add_js() in hook_page_build(), use
    |         | #attached for CSS and JS on the $page render array
    |         | instead
--------------------------------------------------------------------------

Comment #3

apaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

CreditAttribution: apaderno as a volunteer commented 27 January 2019 at 09:32

Status:

Needs work

» Closed (won't fix)

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.

Comment #4

rahul.shinde

he/him

Marathi

Pune

CreditAttribution: rahul.shinde at DevsAdda for HighWire Press, Inc commented 13 April 2019 at 11:53

Status:

Closed (won't fix)

» Active

Now all the issues are fixed. Here is the PAReview link. https://pareview.sh/pareview/https-git.drupal.org-project-hypothesis.git

Thanks, @manish34jain.

@kiamlaluno, sorry for this delay. I'll not let this happen again.

Comment #5

apaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

CreditAttribution: apaderno as a volunteer commented 13 April 2019 at 12:01

Assigned:	Unassigned	» apaderno
Status:	Active	» Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.