Closed (fixed)
Project:
MediaElement
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Major
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
6 Dec 2018 at 01:25 UTC
Updated:
9 Feb 2020 at 18:04 UTC
Jump to comment: Most recent
Comments
Comment #2
chris matthews commentedComment #3
jnettikAdmittedly I hadn't had much a plan for addressing D7 issues anytime soon. I'm open to a 1.3 release with the RTBC patches. I think from Needs Review the patch in #2863615: Update library hook to newest mediaelement javascript library - v4.05 that updates the library version number makes sense (the newer library seems to work fine for me otherwise). If I can get some help testing the other Review issues, they could make it into the next release or following one.
Comment #4
chris matthews commentedThanks jnettik, I will set aside some time to test the other Review issues and report back.
Comment #5
chris matthews commentedI went through the other needs review issues and he's where they stand now:
Patches no longer applied cleanly:
Issue #1154196: Show Description of file
Issue #1348816: Responsive audio and video
Issue #1810314: Path that adds "autoplay" and "loop" functionality
Status changed to RTBC:
Issue #1796028: When 'controls' option is false, js breaks with "$(this).mediaelement is not a function"
Issue #2863615: Update library hook to newest mediaelement javascript library - v4.05
Currently 4 issues left in need review that I am unable to go further with:
Issue #1041054: Autoplay
Issue #1231182: Support <source> and <track> child elements in theme functions.
Issue #1034374: Poster Images
Issue #2167729: Download Library with mediaelement.make for Simple Profile Integration
Comment #6
chris matthews commentedComment #7
jnettikThank you for your help with this. I've been going through the RTBC issues and committing them. I should get to some more this week.
Comment #8
chris matthews commented@jnettik, could you provide a list of open issues that are preventing a 7.x-1.3 release of MediaElement?
Comment #9
jnettikHey Chris,
I apologize for the stagnation of this release. I got a few issues committed and closed, specifically:
#1154196: Show Description of file
#1810314: Path that adds "autoplay" and "loop" functionality
#3026206: Restore 'version' key in library definition
I've closed out #1041054: Autoplay as a duplicate of the other autoplay issue. #1231182: Support <source> and <track> child elements in theme functions. and #1034374: Poster Images seem like larger investments, especially the poster images issue as it would require a lot of questions about the source of the poster. I think both of those have solutions in custom coding, do they seem necessary for the next release?
The two issues remaining in RTBC both relate to YouTube integration (#1802388: MediaElement as YouTube Player and #1119570: Field formatter renders online videos, (youtube, vimeo etc) unplayable). In my testing, the module plays YouTube videos fine using the Link module. I've closed them out for now, both being fairly old.
Lastly, the responsive video issue (#1348816: Responsive audio and video) didn't quite work for me in my testing.
I'm not sure if there's anything remaining that's preventing the 1.3 release now. Is there anything that you see remaining that needs to be a priority before putting out a new release?
Comment #10
chris matthews commentedHey - no worries at all!
I do not think #1231182: Support <source> and <track> child elements in theme functions. and #1034374: Poster Images should prevent a 1.3 release.
However, I do think #1348816: Responsive audio and video should be fixed before the 1.3 release as it's fairly critical for today's web.
Other than that I don't think there are any other issues that need to be fixed before the 1.3 release.
Comment #11
jnettikI would agree with you. From the reply on #1348816-50: Responsive audio and video, I was able to get that committed. I'm going to go through and do some cleanup on older tickets, however if I could get one final test on the latest dev we can RTBC this and get 1.3 out!
Comment #12
jnettikReleased 1.3.