Replace drupal_set_message() with messenger service

Does that make sense to require Drupal Core 8.5+ in masquerade.info.yml and composer.json files?

Btw, the ControllerBase comes with MessengerTrait. So need to inject the messenger service as well as redirect destination.

There's no need to reinject the Messenger service in the controller's constructor, it already extends the class ControllerBase wich has the MessengerTrait.
Replaced the use of the property with the method messenger() from said MessengerTrait.
ContributionWeekend2019

+++ b/src/Controller/SwitchController.php
@@ -80,13 +81,13 @@ class SwitchController extends ControllerBase {
+      $this->messenger->addError($error);

$this->messenger property is NULL by default. I think it is better to rely on $this->messanger().

Assigning

Patch addressing #10

Tests passed after inconsistently failing, because of random build errors.

I can confirm #13 is working who can update this to fixed?

#7 needs to be addressed.

Replaced drupal set message with messenger service

@Neslee Canil Pinto, the path is 65 KB. Did you upload correct file?

Replaced drupal set message with messenger service

@chi it is addressed in #13
@neslee-canil-pinto that patch is an exact copy of the patch #13

Patch in #23 is exact like in #13.

Let's summarize the task.

There is no need to inject messenger service to constructor. The controller extends BaseController which uses MessengerTrait.

However there is a small important detail about accessing the messenger. The trait instantiates the messenger lazily.

public function messenger() {
  if (!isset($this->messenger)) {
    $this->messenger = \Drupal::messenger();
  }
  return $this->messenger;
}

This means you should access the messenger through $this->messenger() method not through $this->messenger property. Given that the whole issue is just about replacing drupal_set_message() with $this->messenger()->addStatus() or $this->messenger()->addError().

@chi thank you for clarifications

Looks good for me. Thanks.