Create the configuration for Image Paragraph type where an image can be uploaded.

CommentFileSizeAuthor
#11 interdiff_4_11.txt1.85 KBharika gujjula
#11 build-image-paragraph-type-config-3014151-11.patch4.17 KBharika gujjula
#8 build-image-paragraph-type-3014151-8.patch3.81 KBbandanasharma
#4 3014151-build-image-paragraph-type.patch3.81 KBharika gujjula

Comments

harika gujjula created an issue. See original summary.

harika gujjula’s picture

harika gujjula commented
Issue summary: View changes
harika gujjula’s picture

harika gujjula commented
Issue summary: View changes
harika gujjula’s picture

harika gujjula commented
StatusFileSize
new 3014151-build-image-paragraph-type.patch3.81 KB

Adding the Patch for Creating Image Paragraph.

harika gujjula’s picture

harika gujjula commented
Assigned: harika gujjula » Unassigned
Status: Active » Needs review
imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented
Status: Needs review » Needs work 
  1. +++ b/config/install/core.entity_view_display.paragraph.image.default.yml
@@ -0,0 +1,23 @@
+    label: above

    The label should be hidden for the field. 

  2. +++ b/config/install/field.field.paragraph.image.field_image.yml
@@ -0,0 +1,37 @@
+  file_extensions: 'png gif jpg jpeg'

    Include svg & gif support as well 

  3. +++ b/config/install/field.field.paragraph.image.field_image.yml
@@ -0,0 +1,37 @@
+  title_field: false

    Enable the title field

imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented 
  1. +++ b/config/install/core.entity_view_display.paragraph.image.default.yml
@@ -0,0 +1,23 @@
+      image_style: ''

    IMO let's keep this to show the original image. If needed for specific conditions then the image style can be applied. 

  2. +++ b/config/install/field.field.paragraph.image.field_image.yml
@@ -0,0 +1,37 @@
+  max_filesize: ''

    Since we will be rendering the original image, let's restrict it to max 2M.

bandanasharma’s picture

bandanasharma commented
Status: Needs work » Needs review
StatusFileSize
new build-image-paragraph-type-3014151-8.patch3.81 KB

I have make changes as per @imalabya comment and create the patch.

imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented
Status: Needs review » Needs work

@bandanasharma thanks for working on this. The patch still doesn't support SVG image uploads.
Also, please add an interdiff file while adding patches if there are any existing patches available. It really helps the reviewer to check the changes.

harika gujjula’s picture

harika gujjula commented
Assigned: Unassigned » harika gujjula
Status: Needs work » Needs review
harika gujjula’s picture

harika gujjula commented
StatusFileSize
new build-image-paragraph-type-config-3014151-11.patch4.17 KB
new interdiff_4_11.txt1.85 KB

Re-added the Patch with all the changes, as there are missing dependencies for the svg_support.

imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented
Status: Needs review » Reviewed & tested by the community

👍Moving to RTBC.

  • harika gujjula committed a482c84 on 8.x-1.x 
    Issue #3014151 by harika gujjula, bandanasharma, imalabya: Build the...
harika gujjula’s picture

harika gujjula commented
Status: Reviewed & tested by the community » Fixed

Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.