Update module does not depend on the File Module

Ah I missed that. So I guess now the question becomes why are we not doing something similar to \Drupal\system\Form\ThemeSettingsForm which detects if the file module is installed. I think the update module offers functionality that's important - ie checking whether your site is up-to-date that is important without the file module.

+++ b/core/modules/update/src/Form/UpdateManagerInstall.php
@@ -111,17 +111,20 @@ public function buildForm(array $form, FormStateInterface $form_state) {
-    $form['information'] = [
-      '#prefix' => '<strong>',
-      '#markup' => $this->t('Or'),
-      '#suffix' => '</strong>',
-    ];
-
-    $form['project_upload'] = [
-      '#type' => 'file',
-      '#title' => $this->t('Upload a module or theme archive'),
-      '#description' => $this->t('For example: %filename from your local computer', ['%filename' => 'name.tar.gz']),
-    ];
+    // Provide upload option only if file module exists.
+    if ($this->moduleHandler->moduleExists('file')) {
+      $form['information'] = [
+        '#prefix' => '<strong>',
+        '#markup' => $this->t('Or'),
+        '#suffix' => '</strong>',
+      ];
+
+      $form['project_upload'] = [
+        '#type' => 'file',
+        '#title' => $this->t('Upload a module or theme archive to install'),
+        '#description' => $this->t('For example: %filename from your local computer', ['%filename' => 'name.tar.gz']),
+      ];
+    }

I was wondering if the change in the form array would affect contrib - looking at http://grep.xnddx.ru/search?text=%27project_upload%27&filename= I don't think so. The unsets will continue to work just fine.

Committed 052816d and pushed to 9.3.x. Thanks!