Improve error message on unrouted URLs

Interesting...this may have been reported in the past but I haven’t yet looked.

Hi i had the same issue but in my case i did not know what was deleted (a node or view or taxonomy or view page path) because i was not the user that deleted the node and this showed up only after clearing the caches.
So at first I tried using drupal console to see the available routes

 vendor/bin/drupal router:debug

but this was not helpful because i was missing a node path.
Now the real question here, is how do you find what are you missing? I had to Log somehow the uri that was creating the white screen of death. So i edited
/web/core/lib/Drupal/Core/Url.php and added at line: 556

    // Logs as errors
    \Drupal::logger('HELPPPP')->error($this->getUri());

Now after this i had this in my admin/reports/dblog
So what i did was to create a new dummy node and add the path alias node/109 for my new dummy node.
The only issue with that was that if i would delete my dummy node then 'boom' my frontpage would break again.
So I searched my files in case there was a node/109 path somewhere (in cache files) but with no luck. So i thought that maybe i am missing something else here because my base path node:109 should exist somewhere. This is where i made a dump sql backup of my db and searched for my missing path node/109 and there it was everywhere.
If found it in

• old_5df252_url_alias (table)
• in a link field table i have in a content type and
• in the revisions field table of the previous link field.

So there it was in 3 tables. Now, i knew exactly where to find my missing node path (it was a link field of another content type that was linking to my old deleted path).
After i replaced /node/109 with my path /taxonomy/term/[tid] everything was working again.

I hope that helps someone in the future.
Maybe a good solution for this would be to update web/core/lib/Drupal/Core/Url.php and at line: 556 and add

      throw new \UnexpectedValueException('External URLs do not have an internal route name. See this '.$this->getUri());

instead of

      throw new \UnexpectedValueException('External URLs do not have an internal route name.');

It is more user friendly and will save a lot of "debugging" time of new drupal 8 developers like me :) in the future.
If this happens again (if you have a link field in an entity type that links to another node that is deleted, i will be in trouble again :) ).

Thanks @Nikitas your suggestion helped me find that I had some absolute paths in my database after migrating a D7 site to D9.

I can confirm that this is still an issue in D9.08 as well. Setting to Active though, since no patch is attached.

It would already really help if the exception in getRouteParameters() and getRouteName() could add some information about the url having the problem. We currently have a complex node with paragraphs etc. Editors are currently not able to find the problematic link and correct it themselves.

this probably should not break in production, but instead log critical errors. This was breaking for us in production because a field did not have the right url. If the user is not able to see click on a deep link on a given page is bad, but if there is a 503 error is even worse :-D

I'll see if I can push/propose something

This issue exists even when a user enters a URL like '/node/345' or '/example-alias' in the URL autocomplete field. Adding a patch based on suggestions in #5 to make debugging easier, till the time a permanent fix is in place.

I think this is related to the same problem I am seeing:

    $url = Url::fromUri("internal:/path-doesnt-exist");
    dump($url->isRouted());

     $route_parameters = $url->getRouteParameters();

which throws 'External URLs do not have internal route parameters'.

This exception is unclear -- it's not an external URL, it's a URL which has been set with the 'base:' scheme because no route was found:

    $url = \Drupal::pathValidator()
      ->getUrlIfValidWithoutAccessCheck($uri_parts['path']) ?: static::fromUri('base:' . $uri_parts['path'], $options);

There needs to be a check somewhere for 'did this get a URL object which is internal?'

Setting to Needs Work, since a patch is attached, however there are still issues mentioned in #15.

The most recent patch doesn't attempt to improve the error message, so #15 doesn't apply. The patch just gives more debug info, which is very helpful. IMO its not worth holding back an improvement any longer.

Resolved CSpell errors

Thanks for the tip @nikitas about your comment at #5

I had a problem with a menu today and your trick help me a lot.

Best

Passes tests, and makes usability better.

> The most recent patch doesn't attempt to improve the error message, so #15 doesn't apply. The patch just gives more debug info, which is very helpful. IMO its not worth holding back an improvement any longer.

I don't understand.

The issue title is about improving the error message. What does the RTBC'd patch do if not that?

Should #15 be dealt with in another issue then? I thought it seemed closely related to this.

Thanks for working on this issue. I think if we are changing the message then is needs to make sense. I'm not sure that External URLs do not have an internal route name. See this ' . $this->getUri() actually helps that much.

If I cause this exception this is what I see:

>>> $a = \Drupal\Core\Url::fromUri('https://www.drupal.org');
=> Drupal\Core\Url {#4673}
>>> $a->getRouteName();
UnexpectedValueException with message 'External URLs do not have an internal route name. See this https://www.drupal.org'

The See this https://www.drupal.org does not make any sense.

I think throw new \UnexpectedValueException($this->getUri() . ' is an external URL and cannot have an internal route name.'); is an improvement but perhaps people have a better idea.

the problem typically does not occur with external urls rather this way:

1. add a link to an existing page, it'll be stored with internal:
2. delete the page
3. Your code which worked before the page delete now fatals.

I was able to reproduce the error thanks to @alexpott's code on #26.

Here is the new patch with his suggested message.

Also, I don't know if it's relevant to the issue, but when I run getRouteName() with an internal link (like 'internal:/foo/bar' as suggested in the IS, or even an existing one) I get a completely different error: Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "path.validator".

I'm not sending an interdiff as the patch alters only one line.

@andregp if you use drush php on an install Drupal you'll get a repl in a bootstrapped Drupal so it'll work like this:

>>> $a = \Drupal\Core\Url::fromUri('internal:/foo/bar');
>>> $a->getRouteName();
UnexpectedValueException with message 'base:foo/bar is an external URL and cannot have an internal route name.'

Which also makes me question the correctness of this message. Perhaps that most simple thing would be to change the message to:
throw new \UnexpectedValueException($this->getUri() . ' has no corresponding route.');

Edit: ah nevermind, alexpott actually addressed my concern. Great!

@alexpott Thanks for the tip.

Looks great.

Committed and pushed 83e1686b69 to 10.0.x and 4da04a22c4 to 9.4.x. Thanks!