Problem/Motivation
The Drupal and DrupalPractice request depency injection

Proposed resolution
Inject objects LanguageManagerInterface

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 webform-drupal_dependence_injection-3011505-3.patch658 bytesthalles
#6 webform-drupal_dependence_injection-3011505-2.patch677 bytesthalles
#2 webform-drupal_dependence_injection-3011505.patch3.85 KBthalles

Comments

Thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new webform-drupal_dependence_injection-3011505.patch3.85 KB

Hi follow the patch!
I hope it can contribute to your beautiful work.

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Needs review

Looks good.

I am switching the 'Status' to 'Needs Review' to get the automated tests to run.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Sorry!
I did not remember to change the status.

Status: Needs review » Needs work

The last submitted patch, 2: webform-drupal_dependence_injection-3011505.patch, failed testing. View results

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new webform-drupal_dependence_injection-3011505-2.patch677 bytes
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new webform-drupal_dependence_injection-3011505-3.patch658 bytes

Follow the patch!

The last submitted patch, 6: webform-drupal_dependence_injection-3011505-2.patch, failed testing. View results

jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

Thanks for the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.