Problem/Motivation
The Drupal and DrupalPractice request depency injection
Proposed resolution
Inject objects
Remaining tasks
------ -----------------------------------------------------------------------------------------------------------------------
Line src/AliasStorageHelper.php
------ -----------------------------------------------------------------------------------------------------------------------
85 \Drupal calls should be avoided in classes, use dependency injection instead
166 Method Drupal\pathauto\AliasStorageHelper::loadBySource() should return array|bool but return statement is missing.
181 Method Drupal\pathauto\AliasStorageHelper::deleteBySourcePrefix() should return bool but return statement is missing.
------ ----------------------------------------------------------------------------------------------------------------------------- -------------------------------------------------------------------------------
Line src/Entity/PathautoPattern.php
------ -------------------------------------------------------------------------------
432 Instantiated class Drupal\pathauto\Entity\ContextNotFoundException not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
------ ------------------------------------------------------------------------------------- --------------------------------------------------------------------------------------------------------
Line src/Form/PatternEditForm.php
------ --------------------------------------------------------------------------------------------------------
277 Method Drupal\pathauto\Form\PatternEditForm::save() should return int but return statement is missing.
------ -------------------------------------------------------------------------------------------------------------- ------------------------------------------------------------------------------
Line src/PathautoGenerator.php
------ ------------------------------------------------------------------------------
150 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------------ -----------------------------------------------------------------------------------------------------
Line src/PathautoItem.php
------ -----------------------------------------------------------------------------------------------------
36 Method Drupal\pathauto\PathautoItem::postSave() should return bool but return statement is missing.
------ ----------------------------------------------------------------------------------------------------------- ------------------------------------------------------------------------------
Line src/PathautoWidget.php
------ ------------------------------------------------------------------------------
41 \Drupal calls should be avoided in classes, use dependency injection instead
51 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------------ ------------------------------------------------------------------------------
Line src/Plugin/Action/UpdateAction.php
------ ------------------------------------------------------------------------------
25 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------------ ------------------------------------------------------------------------------
Line src/Plugin/pathauto/AliasType/EntityAliasTypeBase.php
------ ------------------------------------------------------------------------------
278 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------
User interface changes
API changes
Data model changes
Issue fork pathauto-3011480
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
thallesComment #3
thallesComment #4
berdirNo patch here.
Comment #5
benstallings commentedComment #7
benstallings commentedComment #8
mably commentedClosing as duplicate of #3571944.
Comment #10
mably commented