Problem/Motivation
The Drupal and DrupalPractice request depency injection

Proposed resolution
Inject objects

Remaining tasks

------ -----------------------------------------------------------------------------------------------------------------------
Line src/AliasStorageHelper.php
------ -----------------------------------------------------------------------------------------------------------------------
85 \Drupal calls should be avoided in classes, use dependency injection instead
166 Method Drupal\pathauto\AliasStorageHelper::loadBySource() should return array|bool but return statement is missing.
181 Method Drupal\pathauto\AliasStorageHelper::deleteBySourcePrefix() should return bool but return statement is missing.
------ -----------------------------------------------------------------------------------------------------------------------

------ -------------------------------------------------------------------------------
Line src/Entity/PathautoPattern.php
------ -------------------------------------------------------------------------------
432 Instantiated class Drupal\pathauto\Entity\ContextNotFoundException not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
------ -------------------------------------------------------------------------------

------ --------------------------------------------------------------------------------------------------------
Line src/Form/PatternEditForm.php
------ --------------------------------------------------------------------------------------------------------
277 Method Drupal\pathauto\Form\PatternEditForm::save() should return int but return statement is missing.
------ --------------------------------------------------------------------------------------------------------

------ ------------------------------------------------------------------------------
Line src/PathautoGenerator.php
------ ------------------------------------------------------------------------------
150 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------

------ -----------------------------------------------------------------------------------------------------
Line src/PathautoItem.php
------ -----------------------------------------------------------------------------------------------------
36 Method Drupal\pathauto\PathautoItem::postSave() should return bool but return statement is missing.
------ -----------------------------------------------------------------------------------------------------

------ ------------------------------------------------------------------------------
Line src/PathautoWidget.php
------ ------------------------------------------------------------------------------
41 \Drupal calls should be avoided in classes, use dependency injection instead
51 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------

------ ------------------------------------------------------------------------------
Line src/Plugin/Action/UpdateAction.php
------ ------------------------------------------------------------------------------
25 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------

------ ------------------------------------------------------------------------------
Line src/Plugin/pathauto/AliasType/EntityAliasTypeBase.php
------ ------------------------------------------------------------------------------
278 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------

User interface changes

API changes

Data model changes

Issue fork pathauto-3011480

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Thalles created an issue. See original summary.

thalles’s picture

Status: Needs work » Needs review
thalles’s picture

Assigned: thalles » Unassigned
berdir’s picture

Status: Needs review » Active

No patch here.

benstallings’s picture

Assigned: Unassigned » benstallings
Issue summary: View changes

benstallings’s picture

Assigned: benstallings » Unassigned
Status: Active » Needs review
mably’s picture

Status: Needs review » Closed (duplicate)
Issue tags: -ciandt-contrib, -#ciandt-contrib

Closing as duplicate of #3571944.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

mably’s picture

Related issues: +#3571944: phpstan fixes