Problem/Motivation

Let's see if we can fix some of the PHPStan warnings we get in Gitlab CI.

Issue fork pathauto-3571944

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mably created an issue. See original summary.

mably opened merge request !116

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

similar to how we did it on redirect, I propose to disable phpstan job on previous major.

It tends to be really hard to get them all green with deprecations and can be confusing. unsure on next minor, we might want to know if there are upcoming changes that will break it, especially if we enforce that it must pass.

mably’s picture

mably commented

Ok, I'll have a look at how it was done on redirect module to disable phpstan on previous major.

mably’s picture

mably commented
Status: Active » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

Left some comments, I think a few suggestions are worth doing, such as return an explicit FALSE instead of ignoring it and simplifying the docblock.

Then I think it's fine to merge this.

mably’s picture

mably commented
Status: Needs work » Needs review

I have added that return FALSE;.

  • mably committed 38d8c6ca on 8.x-1.x 
    task: #3571944 phpstan fixes

By: mably
By: berdir
mably’s picture

mably commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.