FILE: ...omy_term_name_depth/src/Plugin/views/argument/IndexNameDepth.php
----------------------------------------------------------------------
FOUND 22 ERRORS AFFECTING 22 LINES
----------------------------------------------------------------------
25 | ERROR | [ ] Missing short description in doc comment
26 | ERROR | [x] Data types in @var tags need to be fully
| | namespaced
55 | ERROR | [ ] Missing short description in doc comment
61 | ERROR | [x] Short array syntax must be used to define arrays
62 | ERROR | [x] Short array syntax must be used to define arrays
63 | ERROR | [x] Short array syntax must be used to define arrays
64 | ERROR | [x] Short array syntax must be used to define arrays
69 | ERROR | [ ] Missing short description in doc comment
73 | ERROR | [x] Short array syntax must be used to define arrays
85 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
89 | ERROR | [x] Short array syntax must be used to define arrays
98 | ERROR | [x] Short array syntax must be used to define arrays
108 | ERROR | [ ] Missing short description in doc comment
115 | ERROR | [x] Short array syntax must be used to define arrays
131 | ERROR | [ ] Missing short description in doc comment
139 | ERROR | [x] Short array syntax must be used to define arrays
155 | ERROR | [x] Short array syntax must be used to define arrays
177 | ERROR | [x] Short array syntax must be used to define arrays
188 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
220 | ERROR | [ ] Missing short description in doc comment
223 | ERROR | [x] Visibility must be declared on method "title"
228 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
----------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | Screenshot 2019-10-08 at 22.14.37.png | 176.5 KB | baikho |
| #7 | 3001139-7.patch | 7.7 KB | rpayanm |
| #3 | coding_standard_3001139_3.patch | 6.74 KB | vdenis |
| #2 | 3001139-coding-standard-2.patch | 5.77 KB | deepanker_bhalla |
Comments
Comment #2
deepanker_bhalla commentedFixed the coding standard issues.
Comment #3
vdenis commentedFound one more issue:
Providing new patch which fixes above coding standards.
Comment #4
deepanker_bhalla commentedThanks for resolving the left over issues. I checked your patch and its working fine.
Comment #5
rakesh.gectcrWhen I try to apply the patch, against the branch, I am getting the following error
Comment #6
rakesh.gectcrComment #7
rpayanmComment #8
vuilComment #9
vuilIt needs to updated A.S.A.P.
Thank you.
Comment #10
vuilComment #11
vuilComment #12
vuilUpdate the issue's title only.
Comment #14
baikho commentedPatch in #7 applies cleanly:
Also tested the plugin which works fine with the changes:
Committed to
6.xdev. Thanks everyone!Comment #15
baikho commentedComment #16
baikho commentedComment #18
vuil