FILE: ...omy_term_name_depth/src/Plugin/views/argument/IndexNameDepth.php
----------------------------------------------------------------------
FOUND 22 ERRORS AFFECTING 22 LINES
----------------------------------------------------------------------
  25 | ERROR | [ ] Missing short description in doc comment
  26 | ERROR | [x] Data types in @var tags need to be fully
     |       |     namespaced
  55 | ERROR | [ ] Missing short description in doc comment
  61 | ERROR | [x] Short array syntax must be used to define arrays
  62 | ERROR | [x] Short array syntax must be used to define arrays
  63 | ERROR | [x] Short array syntax must be used to define arrays
  64 | ERROR | [x] Short array syntax must be used to define arrays
  69 | ERROR | [ ] Missing short description in doc comment
  73 | ERROR | [x] Short array syntax must be used to define arrays
  85 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
  89 | ERROR | [x] Short array syntax must be used to define arrays
  98 | ERROR | [x] Short array syntax must be used to define arrays
 108 | ERROR | [ ] Missing short description in doc comment
 115 | ERROR | [x] Short array syntax must be used to define arrays
 131 | ERROR | [ ] Missing short description in doc comment
 139 | ERROR | [x] Short array syntax must be used to define arrays
 155 | ERROR | [x] Short array syntax must be used to define arrays
 177 | ERROR | [x] Short array syntax must be used to define arrays
 188 | ERROR | [x] Inline comments must end in full-stops,
     |       |     exclamation marks, colons, question marks, or
     |       |     closing parentheses
 220 | ERROR | [ ] Missing short description in doc comment
 223 | ERROR | [x] Visibility must be declared on method "title"
 228 | ERROR | [x] Inline comments must end in full-stops,
     |       |     exclamation marks, colons, question marks, or
     |       |     closing parentheses
----------------------------------------------------------------------

Comments

deepanker_bhalla created an issue. See original summary.

deepanker_bhalla’s picture

Status: Needs work » Needs review
StatusFileSize
new5.77 KB

Fixed the coding standard issues.

vdenis’s picture

StatusFileSize
new6.74 KB

Found one more issue:

➜  views_taxonomy_term_name_depth git:(8.x-6.x) ✗ phpcs --standard=Drupal views_taxonomy_term_name_depth.views.inc

FILE: /Users/denis/Documents/web/issues/views_taxonomy_term_name_depth/views_taxonomy_term_name_depth.views.inc
---------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] The PHP open tag must be followed by exactly one blank line
  1 | ERROR   | [x] Missing file doc comment
  2 | WARNING | [x] Unused use statement
  8 | ERROR   | [x] Short array syntax must be used to define arrays
 11 | ERROR   | [x] Short array syntax must be used to define arrays
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

Time: 58ms; Memory: 6Mb

Providing new patch which fixes above coding standards.

deepanker_bhalla’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for resolving the left over issues. I checked your patch and its working fine.

rakesh.gectcr’s picture

When I try to apply the patch, against the branch, I am getting the following error

Checking patch src/Plugin/views/argument/IndexNameDepth.php...
error: while searching for:
  }

  /**
   * @inheritdoc
   */
  function title() {
    $term = $this->termStorage->load($this->argument);
    if (!empty($term)) {
      return $term->getName();
    }
    // TODO review text
    return $this->t('No name');
  }


error: patch failed: src/Plugin/views/argument/IndexNameDepth.php:218
error: src/Plugin/views/argument/IndexNameDepth.php: patch does not apply
Checking patch views_taxonomy_term_name_depth.views.inc...
rakesh.gectcr’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll
rpayanm’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new7.7 KB
vuil’s picture

Status: Needs review » Reviewed & tested by the community
vuil’s picture

Status: Reviewed & tested by the community » Patch (to be ported)

It needs to updated A.S.A.P.
Thank you.

vuil’s picture

vuil’s picture

vuil’s picture

Title: Coding standard » Apply Drupal coding standards

Update the issue's title only.

  • baikho committed 38d2650 on 8.x-6.x authored by rpayanm
    Issue #3001139 by deepanker_bhalla, vdenis, rpayanm: Apply Drupal coding...
baikho’s picture

Status: Patch (to be ported) » Fixed
StatusFileSize
new176.5 KB

Patch in #7 applies cleanly:

views_taxonomy_term_name_depth on  8.x-6.x 
➜ git apply -v 3001139-7.patch 
Checking patch src/Plugin/views/argument/IndexNameDepth.php...
Checking patch views_taxonomy_term_name_depth.views.inc...
Applied patch src/Plugin/views/argument/IndexNameDepth.php cleanly.
Applied patch views_taxonomy_term_name_depth.views.inc cleanly.

Also tested the plugin which works fine with the changes:

capitalised first letter missing dependency

Committed to 6.x dev. Thanks everyone!

baikho’s picture

baikho’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vuil’s picture