tep to reproduce on 8.6:

-create a group
-delete this group

you will get this error:

Error: Call to a member function addMessage() on null in Drupal\block_visibility_groups\Form\BlockVisibilityGroupDeleteForm->submitForm() (line 62 of modules/contrib/block_visibility_groups/src/Form/BlockVisibilityGroupDeleteForm.php).
CommentFileSizeAuthor
#4 interdiff-2-4.txt872 byteshctom
#4 block_visibility_groups_3000396-4.patch551 byteshctom
#2 block_visibility_groups_3000396_2.patch972 bytesbala.addweb

Comments

DuneBL created an issue. See original summary.

bala.addweb’s picture

bala.addweb commented
Status: Active » Needs review
StatusFileSize
new block_visibility_groups_3000396_2.patch972 bytes

@DuneBL, Please find my attached patch that solves the mentioned error.

dunebl’s picture

dunebl
Primary language French
commented

@nikunj.addweb thank you for the patch!
I confirm it solves the issue

hctom’s picture

hctom
Primary language German
commented
StatusFileSize
new block_visibility_groups_3000396-4.patch551 bytes
new interdiff-2-4.txt872 bytes

The supplied patch solves the error, but not the actual problem ;) So here is a new patch that really outputs the desired message by fixing the wrong implementation of the messenger service. $this->messenger property was used directly instead of $this->messenger() method which instantiates the service if it does not exist already.

patrickmichael’s picture

patrickmichael commented

Patch #4 worked for me, thank you for this.

jnettik’s picture

jnettik
Primary language English
Location Denver, CO
commented
Status: Needs review » Reviewed & tested by the community

I can also confirm the patch in #4 works. Thank you!

7thkey’s picture

7thkey commented

Patch #4 works for me. Thx!

scotwith1t’s picture

scotwith1t
Location Birmingham, AL
commented
Version: 8.x-1.3 » 8.x-1.x-dev

Another +1 for #4. Thanks :)

finex’s picture

finex commented

Thanks for the patch!

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented

#4 works on 8.6.

brightbold’s picture

brightbold
she/her
Primary language English
Location Boston, MA
commented

Patch in #4 also solved the problem for me on 8.6. +1!

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Priority: Minor » Normal

This is not a minor problem, but thanks for the patch! 8.7 issue as well.

  • joelpittet committed eed1d6e on 8.x-1.x authored by hctom 
    Issue #3000396 by hctom, nikunj.addweb, DuneBL, PatrickMichael, jnettik...
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

Thanks I've committed this to the latest dev release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

chris matthews’s picture

chris matthews commented

@maintainers, would it be possible to push this fix to a 8.x-1.4 release?