Problem/Motivation

#2918421: Don't display the activity chart if no activity has occurred and #2996846: Page manager config in hook_install doesn't get updated got me thinking that it would be useful to provide test coverage for components of the Moderation Dashboard which tests that the expected components exist on the page.

Proposed resolution

Create a functional test for moderation dashboard block plugins:

  • Content in review
  • Content drafts
  • Editor activity for the last 30 days
  • Recent updates
  • Recently created

Remaining tasks

Provide a patch.

User interface changes

Nothing.

API changes

Nothing.

Data model changes

Nothing.

CommentFileSizeAuthor
#7 interdiff-2998490-4-6.txt3.8 KBsamuel.mortenson
#7 2998490-6.patch3.07 KBsamuel.mortenson
#4 moderation_dashboard-add_component_test-2998490-4.patch3.56 KBhuzooka
#2 moderation_dashboard-add_component_test-2998490-2.patch3.69 KBhuzooka

Comments

huzooka created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: huzooka » Unassigned
Status: Active » Needs review
StatusFileSize
new moderation_dashboard-add_component_test-2998490-2.patch3.69 KB

Uploaded a patch which adds the component test.

Note that the provided test won't pass until #2996846: Page manager config in hook_install doesn't get updated is merged.

Status: Needs review » Needs work

The last submitted patch, 2: moderation_dashboard-add_component_test-2998490-2.patch, failed testing. View results

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new moderation_dashboard-add_component_test-2998490-4.patch3.56 KB

Simplified test, without protected $user

Status: Needs review » Needs work

The last submitted patch, 4: moderation_dashboard-add_component_test-2998490-4.patch, failed testing. View results

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Needs work » Needs review
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
StatusFileSize
new 2998490-6.patch3.07 KB
new interdiff-2998490-4-6.txt3.8 KB

Shifted some logic around, removed the "60 days ago" time since it didn't affect test success/failure - but we can add that back if we need it later on.

  • samuel.mortenson committed 4ffe4c4 on 8.x-1.x 
    Issue #2998490 by huzooka, samuel.mortenson: Add functional test for...
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Needs review » Fixed

Thanks for the contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.