Problem/Motivation

ModerationDashboardTest fails since it's tries to test with Workbrench Moderation module, but it's isn't required neither as hard nor test (dev) dependency.
See https://www.drupal.org/pift-ci-job/1058189

Proposed resolution

  • Convert test to use Content Moderation module provided by Drupal core.
  • Add Workbrench moderation as test dependency.
  • Provide a legacy test for the case if Workbrench Moderation is used.

Remaining tasks

Provide a patch

User interface changes

Nothing.

API changes

Nothing.

Data model changes

Nothing.

CommentFileSizeAuthor
#9 2998136-9.patch2.13 KBsamuel.mortenson
#8 moderation_dashboard-fix_test-2998136-8.patch9.55 KBhuzooka
#5 moderation_dashboard-fix_test-2998136-5.patch7.34 KBhuzooka
#2 moderation_dashboard-fix_test-2998136-2.patch7.63 KBhuzooka

Comments

huzooka created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new moderation_dashboard-fix_test-2998136-2.patch7.63 KB

Let's see what happens.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented

Invalid chars in patch #2

Status: Needs review » Needs work

The last submitted patch, 2: moderation_dashboard-fix_test-2998136-2.patch, failed testing. View results

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new moderation_dashboard-fix_test-2998136-5.patch7.34 KB

Let's try it again.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented

@samuel.mortenson, could you please review these changes, especially the newly added composer.json?

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: Unassigned » huzooka
Category: Bug report » Task
Status: Needs review » Needs work
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: huzooka » Unassigned
Status: Needs work » Needs review
StatusFileSize
new moderation_dashboard-fix_test-2998136-8.patch9.55 KB

Added submodule dependencies to the new composer.json in root.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
StatusFileSize
new 2998136-9.patch2.13 KB

Thanks for working on this. I've fixed the coding standards in a commit because they aren't causing tests to fail, and am uploading a patch that minimally fixes tests. We can't add new composer dependencies on moderation_note or scheduled_updates as they are not dependencies of the base module - doing this would download two new modules for all users. I've added workbench moderation as a test dependency which should fix tests.

If we want to officially drop Workbench Moderation support, or add new test coverage, we should do that in a new issue.

Status: Needs review » Needs work

The last submitted patch, 9: 2998136-9.patch, failed testing. View results

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Needs work » Fixed

Quirk with the test bot - new test_dependencies are only processed when in a branch/tag. Tests passing now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.