String doesn't get changed when additional Languages istalled afterwards [#2998133]

Issue summary updated as of comment #10

Problem/Motivation

It seems there is a bug in the translation system

Tested with

Drupal Core Vanilla 8.6.0 on simpletest.me

Affected string: Default long date On Date- and Time format page

Steps to reproduce

Install Drupal in English
Add German
And /Or French

Change the Default language of the site.

The Description string is still as well as the heading pattern on the date format edit page ist still English

This doesn't happen if you install Drupal in just one language. because the translation is available.

Maybe cache should be cleared after a new translation is installed automatically to solve this bug.

Proposed resolution

Locate the mentioned strings and use one of the translation methods.

Remaining tasks

The date format edit page still isn't being translated.

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#26	interdiff_24-26.txt	608 bytes	ankit_rathore
#26	2998133-26.patch	2.2 KB	ankit_rathore
#25	2998133-25.patch	2.08 KB	Aadhar_Gupta
#24	interdiff_23-24.txt	690 bytes	ankit_rathore
#24	2998133-24.patch	2.19 KB	ankit_rathore
#23	interdiff_20-23.txt	1.81 KB	sahil.goyal
#23	2998133-23.patch	2.08 KB	sahil.goyal
#20	2998133-20.patch	721 bytes	amanshukla6158
#18	interdiff_11-18.txt	548 bytes	pooja saraah
#18	2998133-18.patch	616 bytes	pooja saraah
#16	before patch.png	111.13 KB	anjali rathod
#16	patch applied.png	145.91 KB	anjali rathod
#16	after patch.png	109.97 KB	anjali rathod
#11	14626580-11.patch	609 bytes	wagnerarao

Issue fork drupal-2998133

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

2998133-string-doesnt-get compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

7 September 2018 at 14:32

Joachim Namyslo created an issue. See original summary.

Comment #2

joachim namyslo

German

Kulmbach 🇩🇪 🇪🇺

commented 8 September 2018 at 06:48

Title:	t-function missing on /admin/config/regional/date-time/formats/manage/long/translate/xx/edit	» String doesn't get change when additional Languages istalled afterwards
Issue summary:	View changes

Comment #3

8 September 2018 at 06:48

Version:

8.6.x-dev

» 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #4

8 September 2018 at 06:48

Version:

8.8.x-dev

» 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #5

8 September 2018 at 06:48

Version:

8.9.x-dev

» 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #6

8 September 2018 at 06:48

Version:

9.2.x-dev

» 9.3.x-dev

Comment #7

8 September 2018 at 06:48

Version:

9.3.x-dev

» 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #8

quietone commented 7 July 2022 at 10:40

Component:	user interface text	» config_translation.module
Issue tags:		+Bug Smash Initiative, +Needs issue summary update, +Novice

I tested this on Drupal 9.5.x and can confirm that the translations for the name of the date format are not displayed.

This also needs an issue summary update, see Write an issue summary for an existing issue for guidance. That is suitable for a novice, adding tag.

Comment #9

wagnerarao commented 22 July 2022 at 18:24

Assigned:

Unassigned

» wagnerarao

Hi, let me work on this!

Comment #10

wagnerarao commented 26 July 2022 at 19:57

Issue summary:

View changes

Comment #11

wagnerarao commented 26 July 2022 at 20:06

Status	File	Size
new	14626580-11.patch	609 bytes

Please kindly review this patch. I wasn't able to fix the translation in the heading pattern on the date format edit page, but is working on the name of the date.

Comment #12

wagnerarao commented 26 July 2022 at 20:06

Assigned:	wagnerarao	» Unassigned
Status:	Active	» Needs review

Comment #13

dishakatariya commented 27 July 2022 at 05:36

Assigned:

Unassigned

» dishakatariya

Comment #14

dishakatariya commented 27 July 2022 at 09:49

Assigned:

dishakatariya

» Unassigned

Comment #15

anjali rathod

English

India

commented 12 September 2022 at 09:14

Assigned:

Unassigned

» anjali rathod

Comment #16

anjali rathod

English

India

commented 12 September 2022 at 09:16

Assigned:	anjali rathod	» Unassigned
Status:	Needs review	» Reviewed & tested by the community

Status	File	Size
new	after patch.png	109.97 KB
new	patch applied.png	145.91 KB
new	before patch.png	111.13 KB

Patch #11 applies successfully. Attaching screenshot below.
Thanks all!
Changing the status to RTBC .

Comment #17

quietone commented 12 September 2022 at 09:27

Status:

Reviewed & tested by the community

» Needs work

@Anjali Rathod, thanks for the interest in this patch and testing. For Drupal there are other things that need to happen before a patch can be RTBC. There are several steps, or gates, that an issue must pass before it is marked RTBC. For most issues following step 10 in the Review a patch or merge request task of the Contributor guide is sufficient. The complete list of core gates has more topics. Also, check the tags on the issue and make sure they are complete.

+++ b/core/modules/system/src/DateFormatListBuilder.php
@@ -63,7 +63,7 @@ public function buildHeader() {
+    $row['label'] = t($entity->label());

s/t/$this->t/

Comment #18

pooja saraah commented 12 September 2022 at 11:45

Status	File	Size
new	2998133-18.patch	616 bytes
new	interdiff_11-18.txt	548 bytes

Addressed the comment #17
Thanks @quietone for the suggestion
Attached patch against Drupal 9.4.x

Comment #19

12 September 2022 at 11:45

Version:

9.4.x-dev

» 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #20

amanshukla6158 commented 10 March 2023 at 05:10

Status:

Needs work

» Needs review

Status	File	Size
new	2998133-20.patch	721 bytes

Attached patch against Drupal 10.1.x

Comment #21

joachim namyslo

German

Kulmbach 🇩🇪 🇪🇺

commented 13 March 2023 at 05:13

Title:

String doesn't get change when additional Languages istalled afterwards

» String doesn't get changed when additional Languages istalled afterwards

Comment #22

smustgrave commented 13 March 2023 at 23:16

Status:	Needs review	» Needs work
Issue tags:		+Needs Review Queue Initiative, +Needs tests

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue under control, following Review a patch or merge request as a guide.

Next step would be to add a test case showing the issue.

Comment #23

sahil.goyal commented 16 March 2023 at 08:10

Status	File	Size
new	2998133-23.patch	2.08 KB
new	interdiff_20-23.txt	1.81 KB

Fixing the CCF in #20, updating patch along with interdiff.

Comment #24

ankit_rathore commented 16 March 2023 at 10:18

Status	File	Size
new	2998133-24.patch	2.19 KB
new	interdiff_23-24.txt	690 bytes

trying to fix ccf #23
34 | ERROR | Parameter $time is not described in comment
| | (Drupal.Commenting.FunctionComment.ParamMissingDefinition)

by describing $time in comment

Comment #25

Aadhar_Gupta commented 16 March 2023 at 10:50

Status:

Needs work

» Needs review

Status	File	Size
new	2998133-25.patch	2.08 KB

Fixing CCF error in #24

Comment #26

ankit_rathore commented 16 March 2023 at 11:14

Status:

Needs review

» Needs work

Status	File	Size
new	2998133-26.patch	2.2 KB
new	interdiff_24-26.txt	608 bytes

fixed ccf in #24

Comment #27

smustgrave commented 16 March 2023 at 14:01

Updating credit.

Comment #28

kristen pol

she/her

English

Santa Cruz, CA, USA

commented 6 June 2023 at 19:59

Issue tags:

+Pittsburgh 2023

I’m triaging for DrupalCon mentored contribution and reviewing as this issue is tagged novice.

*******
Please leave this issue for DrupalCon mentored contribution as a possible first time issue.

*******
Next step is to review and work on the patch provided so it’s not failing.

Comment #29

kristen pol

she/her

English

Santa Cruz, CA, USA

commented 6 June 2023 at 20:28

Issue tags:

-Pittsburgh 2023

+Pittsburgh2023

Tag normalization happening:)

Comment #30

6 June 2023 at 20:28

Version:

9.5.x-dev

» 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #31

6 June 2023 at 20:28

Version:

11.x-dev

» main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.