Hi,
I was just exploring the D8 port and it took me some hunting to figure out where to get started after installing ( I checked Devel routing info to find the settings page).
I think the module could use those basics hints, and I'm not here to complain, but willing to pitch in and do it.
Patch to follow, soon.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | applenews-2996702-11.patch | 2.16 KB | brianfisher |
| #6 | applenews-2996702-6.patch | 2.23 KB | bandanasharma |
| #5 | after-patch-AppleNews.png | 66.54 KB | bandanasharma |
| #4 | 2996702-3.patch | 2.2 KB | bryrock |
| #2 | 2996702-2.patch | 2.2 KB | bryrock |
Comments
Comment #2
bryrock commentedOk. Here's the patch.
Comment #4
bryrock commentedOops! I diffed in reverse and removed my changes. Here's the correct patch
Comment #5
bandanasharma commented@bryrock patch is apply successfully and changes reflect on help page. Attached the after patch apply screen shot.
But there is one minor issue into the info file that is dependencies not define according to drupal standard.
It should be like that:
Comment #6
bandanasharma commentedMake dependencies change in the info file and upload the patch.
Comment #7
bandanasharma commentedComment #8
bryrock commented#6 also works for me. I did not address the existing code, one way or another, just added some.
@bandanasharma, thanks for the tip on dependencies standard. I see it is now documented, though it's still rarely seen in contributed (and some core) projects.
If there are no objections, I will commit.
Comment #9
bryrock commentedOk. So I did commit, but I don't have write permission for this repository, so I couldn't push it up.
Comment #10
bandanasharma commented@bryrock Only this module maintainers are push the code not other.
Comment #11
brianfisher commentedre-roll
Comment #14
brianfisher commented