Hi,

I was just exploring the D8 port and it took me some hunting to figure out where to get started after installing ( I checked Devel routing info to find the settings page).

I think the module could use those basics hints, and I'm not here to complain, but willing to pitch in and do it.

Patch to follow, soon.

CommentFileSizeAuthor
#11 applenews-2996702-11.patch2.16 KBbrianfisher
#6 applenews-2996702-6.patch2.23 KBbandanasharma
#5 after-patch-AppleNews.png66.54 KBbandanasharma
#4 2996702-3.patch2.2 KBbryrock
#2 2996702-2.patch2.2 KBbryrock

Comments

bryrock created an issue. See original summary.

bryrock’s picture

bryrock commented
Assigned: bryrock » Unassigned
Status: Active » Needs review
StatusFileSize
new 2996702-2.patch2.2 KB

Ok. Here's the patch.

Status: Needs review » Needs work

The last submitted patch, 2: 2996702-2.patch, failed testing. View results

bryrock’s picture

bryrock commented
Status: Needs work » Needs review
StatusFileSize
new 2996702-3.patch2.2 KB

Oops! I diffed in reverse and removed my changes. Here's the correct patch

bandanasharma’s picture

bandanasharma commented
Status: Needs review » Needs work
StatusFileSize
new after-patch-AppleNews.png66.54 KB

@bryrock patch is apply successfully and changes reflect on help page. Attached the after patch apply screen shot.
But there is one minor issue into the info file that is dependencies not define according to drupal standard.
It should be like that: 

dependencies:
  - drupal:serialization
bandanasharma’s picture

bandanasharma commented
StatusFileSize
new applenews-2996702-6.patch2.23 KB

Make dependencies change in the info file and upload the patch.

bandanasharma’s picture

bandanasharma commented
Status: Needs work » Needs review
bryrock’s picture

bryrock commented
Status: Needs review » Reviewed & tested by the community

#6 also works for me. I did not address the existing code, one way or another, just added some.

@bandanasharma, thanks for the tip on dependencies standard. I see it is now documented, though it's still rarely seen in contributed (and some core) projects.

If there are no objections, I will commit.

bryrock’s picture

bryrock commented

Ok. So I did commit, but I don't have write permission for this repository, so I couldn't push it up.

bandanasharma’s picture

bandanasharma commented

@bryrock Only this module maintainers are push the code not other.

brianfisher’s picture

brianfisher commented
StatusFileSize
new applenews-2996702-11.patch2.16 KB

re-roll

  • tbfisher committed 9b231e4 on 8.x-1.x 
    Issue #2996702 by bryrock, bandanasharma, tbfisher: Add Config and Help...

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: applenews-2996702-11.patch, failed testing. View results

brianfisher’s picture

brianfisher commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.