Closed (fixed)
Project:
Address
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
31 Aug 2018 at 15:31 UTC
Updated:
18 Jun 2019 at 09:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
aheredia commentedAdded a default formatter
Comment #3
aheredia commentedComment #4
aheredia commentedComment #5
miksha commentedAfter applying this patch I am not getting more warning messages, and field settings for allowed number of values is still set to 1 with no options to configure. But when I populate fields I can add multiple number of values, not just one. I did rebuild cache after applying the patch.
Comment #6
bojanz commentedThe widget is address_zone_default, the field type is address zone, the formatter can't be zone_default, needs to also be prefixed with address_
Wrong class name in docblock.
Our other formatters call this method viewElement, let's do the same here. Also, let's pass a Zone object ($item->value).
You don't need the !empty.
We shouldn't abbreviate element names. "dependent_locality", not "dlocality",
Also, dependent_locality should come after locality, not before.
Let's use the "item" type and give each element an appropriate label.
Also, we're not printing the zone label.
Comment #7
bojanz commentedHere's an updated patch.
Comment #9
bojanz commentedLet's proceed. We can open follow-up issues for any other zone bugs.
Thanks, everyone.