when we go to /admin/config/search/xmlsitemap/settings
And in advance setting form changed the baseurl from http://default/ to my site url.
After saving configuration the configuration is not saved. When we come back to /admin/config/search/xmlsitemap/settings and checked the advance form baseurl its again changed to http://default/.
When i debugged the XmlSitemapSettingsForm.php it is not coming into submitForm function on clicking on save configuration.

CommentFileSizeAuthor
#10 xmlsitemap-base-url-config-2990194-10-8.x.patch8.16 KBeduardo morales alberti
#7 xmlsitemap-base-url-config-2990194-7-8.x.patch8.12 KBeduardo morales alberti
#4 xmlsitemap-2990194-base-url-config.patch5.63 KBnatemow

Comments

mahtab_alam created an issue. See original summary.

shreya shetty’s picture

shreya shetty commented

Works as expected. I installed this module and under ADVANCED SETTINGS - Default base URL had prefilled value which was my site name and that will be the base URL of your website

mahtab_alam’s picture

mahtab_alam commented

Can you try this in your local enviornment with using virtual host. By default it will be http://default and if you rename that base url field the value is not saved.

natemow’s picture

natemow commented
Related issues: +#2951689: Allow alter base url for sitemap, +#2999856: Allow Override of Base URL in settings.php
StatusFileSize
new xmlsitemap-2990194-base-url-config.patch5.63 KB

Here's a patch to the alpha3 release to change xmlsitemap_base_url from a State setting to a configurable/exportable Config value. To override the new variable in settings.php, use this:

$config['xmlsitemap.settings']['xmlsitemap_base_url'] = 'https://example.com';

natemow’s picture

natemow commented
Version: 8.x-1.x-dev » 8.x-1.0-alpha3
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 8.x-1.0-alpha3 » 8.x-1.x-dev
Status: Active » Needs work

I think I agree and I want to take a deeper look if it makes sense to move this to config. In the meantime, we'll need to have a patch that is against 8.x-1.x branch. Also feel free to rename the config item 'base_url' instead of 'xmlsitemap_base_url' since we're already in the xmlsitemap.settings config object.

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
StatusFileSize
new xmlsitemap-base-url-config-2990194-7-8.x.patch8.12 KB

Add patch, change name to base_url instead of xmlsitemap_base_url and added it to the install to get the old value from the Drupal state.

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Status: Needs work » Needs review

Updated patch, change status to needs review.

Status: Needs review » Needs work

The last submitted patch, 7: xmlsitemap-base-url-config-2990194-7-8.x.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new xmlsitemap-base-url-config-2990194-10-8.x.patch8.16 KB

Fix patch to pass phpunit tests.

shreyal999’s picture

shreyal999 commented

The module is working as expected, have installed the module and updated the url path for 'Default base URL' and 'Sitemap cache directory' and even on saving the values are what i have set it to be. Couldn't reproduce the issue.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Needs review » Closed (duplicate)

I closed it because of duplication (see related issues), and it is overridden by them.