As a developer of an application that requires multiple environments, each with a different base url, I would like the ability to specify my Default Base URL in settings.php.
Currently this module uses the State API for this setting which allows me to set a unique Default Base URL in each environment without risk of override via a config import. However, I must set this state manually for each environment via the module's settings page or via CLI. Allowing an override of this setting in settings.php using the $settings variable will allow me to define an environment's unique Default Base URL along with all of its other unique settings.

CommentFileSizeAuthor
#16 xmlsitemap-2999856-16.patch3.17 KBpifagor
#12 2999856-11.patch3.18 KBrob holmes
#10 2999856-10.patch2.86 KBrob holmes
#9 2999856-alpha2-9.patch3.99 KBMerryHamster
#5 2999856-alpha2-5.patch3.88 KBMerryHamster
#4 xmlsitemap-allow_base_url_override_in_settings_php-2999856-3.patch4.5 KBarrow
#2 xmlsitemap-allow_base_url_override_in_settings_php-2999856-1.patch4.56 KBarrow

Comments

Arrow created an issue. See original summary.

arrow’s picture

arrow
Location Chicago
commented
StatusFileSize
new xmlsitemap-allow_base_url_override_in_settings_php-2999856-1.patch4.56 KB

The attached patch allows you to set your default base URL by setting xmlsitemap_base_url in your settings.php like so:

$settings['xmlsitemap_base_url'] = 'http://www.example.com';

This will override any value previously set during installation of the module or set via the module settings page. It also disables the Default Base URL field on the settings page.

arrow’s picture

arrow
Location Chicago
commented
Status: Active » Needs review
arrow’s picture

arrow
Location Chicago
commented
StatusFileSize
new xmlsitemap-allow_base_url_override_in_settings_php-2999856-3.patch4.5 KB

Fixed a line error in the patch.

MerryHamster’s picture

MerryHamster commented
StatusFileSize
new 2999856-alpha2-5.patch3.88 KB

I use "version": "1.0.0-alpha2" and patch #4 doesn't work for me.
So I created the patch from #4 for one.

MerryHamster’s picture

MerryHamster commented

Status: Needs review » Needs work

The last submitted patch, 5: 2999856-alpha2-5.patch, failed testing. View results

MerryHamster’s picture

MerryHamster commented
Status: Needs work » Needs review
MerryHamster’s picture

MerryHamster commented
StatusFileSize
new 2999856-alpha2-9.patch3.99 KB

Added a little fix for the patch from #5 for 'alpha2' version.

-      '#default_value' => $this->state->get('xmlsitemap_base_url'),
+      '#default_value' => $base_url_override ? $base_url_override : $this->state->get('xmlsitemap_base_url'),
rob holmes’s picture

rob holmes commented
StatusFileSize
new 2999856-10.patch2.86 KB

Re-roll

Status: Needs review » Needs work

The last submitted patch, 10: 2999856-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

rob holmes’s picture

rob holmes commented
StatusFileSize
new 2999856-11.patch3.18 KB

Reinstate missing use Drupal\Core\Site\Settings;

karens’s picture

karens commented
Status: Needs work » Needs review

We've run into this as well. We need to be able to deploy a number of new sites automatically from configuration and we don't want to have to manually configure this each time.

karens’s picture

karens commented
Status: Needs review » Reviewed & tested by the community

Seems to work fine and tests pass.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Instead of: $base_url_override ? TRUE : FALSE;
You can do: (bool) $base_url_override

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new xmlsitemap-2999856-16.patch3.17 KB
alex_optim’s picture

alex_optim
Location Tallinn
commented
Status: Needs review » Reviewed & tested by the community
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented

  • pifagor committed 46aaab3 on 8.x-1.x 
    Issue #2999856 by Arrow, MerryHamster, Rob Holmes, pifagor, KarenS, Liam...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented

Nice work! Finally I found this one when I was halfway through changing the base URL to $GLOBALS['base_url'] everywhere. I wonder if this still wouldn't be a nice addition that if the Settings was omitted to fallback to $GLOBALS['base_url']. By that the value could also simply be passed from the --uri option using Drush.

drush -y xmlsitemap:rebuild --uri=example.com