In block_class_help(), the deprecated function \Drupal::url() is being called. This should be replaced with Url::fromRoute().

CommentFileSizeAuthor
#2 block_class_deprecated_url_function-2989286-2.diff966 bytesAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at Ashday Interactive Systems commented

JKerschner created an issue. See original summary.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at Ashday Interactive Systems commented
Title: Replace use of deprecated \Drupal::url » Replace use of deprecated \Drupal::url()
Status: Active » Needs review
FileSize
block_class_deprecated_url_function-2989286-2.diff966 bytes
Vidushi Mehta’s picture

Vidushi Mehta CreditAttribution: Vidushi Mehta at gai Technologies Pvt Ltd commented
Status: Needs review » Reviewed & tested by the community

This looks good.
As per "Deprecated" notice on public static function Drupal::url"

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented

really works good +1

  • RenatoG committed d77c4eb on 8.x-1.x authored by JKerschner 
    Issue #2989286 by JKerschner, Vidushi Mehta, RenatoG: Replace use of...
renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to the dev branch.

Thank you very much.

Best

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews commented
Parent issue: » #3093430: Plan for Block Class 8.x-1.1 release