[D8] Mediteran administrator

Hello bataboza,

Please run automated review and check the errors.

Here is the report. https://pareview.sh/pareview/https-git.drupal.org-project-mediteran.git

Thanks

To the reviewers: Please set the priority to Normal after reviewing the project.

Automated Review

Review of the 8.x-1.x branch (commit e971588):

• ESLint has found some issues with your code (please check the JavaScript coding standards).
  

  /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/mobile.install.es6.js: line 1, col 2, Error - Use the function form of 'use strict'. (strict)
  /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/mobile.install.js: line 8, col 2, Error - Use the function form of 'use strict'. (strict)
  /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/nav-tabs.es6.js: line 9, col 2, Error - Use the function form of 'use strict'. (strict)
  /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/nav-tabs.js: line 8, col 2, Error - Use the function form of 'use strict'. (strict)
  /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/responsive-details.es6.js: line 6, col 2, Error - Use the function form of 'use strict'. (strict)
  /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/responsive-details.js: line 8, col 2, Error - Use the function form of 'use strict'. (strict)
  
  6 problems
  

This automated report was generated with PAReview.sh, your friendly project application review script.

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

No: Does not follow the guidelines for 3rd party assets/code. Icons

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. (*) 3rd party icons are included, you should remove them and load them via libraries module
2. (*) Javascripts from seven theme, could be attached like core libraries e.g. : seven/install-page

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Looks OK. Copying assets from core is certainly not the best pratice, better link directly to core assets or include style libraries.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.