[D8] OwlCarousel2

Thank you for your contribution!

We just accept one application per user. Any application opened after the first one is closed settings its status to Closed (duplicate).
The purpose of these applications is not reviewing every project, but give users the vetted role, which allows them to change the status of their projects (the ones they already created or the ones they will create).

Automated Review

Review of the 8.x-1.x branch (commit da2eeff):

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Followsthe licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements. / No: List of security issues identified.]

Coding style & Drupal API usage

1. (*) my test on simplytest.me (https://dfljs.ply.st/) failed when adding an image to a carousel with "Failed to create style directory: public://styles/thumbnail/public/owlcarousel2" https://dfljs.ply.st/admin/reports/dblog/event/40 and some more errors:
2. (*) "Unable to generate the derived image located at public://styles/thumbnail/public/owlcarousel2/Bildschirmfoto 2018-07-12 um 12.26.02.png."
3. (*) "Warning: array_flip(): Can only flip STRING and INTEGER values! in Drupal\Core\Entity\EntityStorageBase->loadMultiple() ..."
4. (*) "TypeError: Argument 1 passed to Drupal\file\FileUsage\DatabaseFileUsageBackend::delete() must implement interface Drupal\file\FileInterface, null given, called"
5. (+) maybe you should write a specific browser test to test common workflows on a clean server.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Hi @yuriseki

Very nice module, it will help a lot of peoples. i have tried it on my local and it works just fine for me. Very nice effect and range of configuration for slider.

Great Module

Hi @yuriseki,

I can confirm the problem with simplytest.me and images styles. I opened an issue: https://www.drupal.org/project/simplytest/issues/2986051

I found this for including external libraries in simplytest.me, try to include a make file:
https://simplytest.me/qa#developers (What about modules depending on external libraries?)
http://engineeredweb.com/blog/10/2/downloading-dependencies-drush-make/

While I find convenient to test a module on simplytest.me, I think we cannot ask users to write extra code just to allow the module to be tested on a site with a bug.

No issues found any more

Thank you for your contribution!

I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.