Hi!

SumoMe Tools integrates the http://www.sumo.com javascript library on all pages of the site, in the <head> section of a Drupal 8 site.

It differs from other library integrations as one has to configure a Site-ID variable. The module provides the configuration form for this integration to take place.

The code added to the page <head> should have this format:

<script src="https://load.sumome.com/" data-sumo-site-id="53952d2c3e28f0cee652bdf9663e1eddba2e7fb5a28ec2a6bf91da06d9ac4df4" async="async"></script>

Here is the project page: SumoMe Tools
Here is the git clone command: git clone --branch 8.x-1.x https://git.drupal.org/project/sumome_tools.git

Manual reviews of other projects

I hope I haven't forgotten anything, thanks for your time

Franck Horlaville
TAM Software

Comments

tamsoftware created an issue. See original summary.

tamsoftware’s picture

tamsoftware CreditAttribution: tamsoftware commented
Issue summary: View changes
PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectsumome_toolsgit

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

tamsoftware’s picture

tamsoftware CreditAttribution: tamsoftware commented
Issue summary: View changes
tamsoftware’s picture

tamsoftware CreditAttribution: tamsoftware commented
Status: Needs work » Needs review

All PAReview issues have been fixed
https://pareview.sh/node/1632

tamsoftware’s picture

tamsoftware CreditAttribution: tamsoftware commented
Issue summary: View changes
yseki’s picture

yseki CreditAttribution: yseki as a volunteer and commented
Status: Needs review » Needs work

Hello tamsoftware,

Here are my comments:

Manual Review

Individual user account

Yes: Follow the guidelines for individual user accounts.

No duplication

No: Have you looked at SumoMe Tools integration module? If yes, how your module differs from the SumoMe Tools integration?

Master Branch

Yes

Licensing

Yes

3rd party assets/code

Yes

README.txt/README.md

Yes

Code long/complex enough for review

No: Does not follow the guidelines for project length and complexity.
This project has too few line codes, and it's not possible to have a good idea about how familiar you are with the Drupal Code Style.

Secure code

Yes

Coding style & Drupal API usage

1. The SumoMeToolsForm at the method submitForm, as it is a static method, you don't need to return any parameter.

Another comments

1. After install the SumoMe tools module, all pages are with this error: Notice: Undefined offset: 1 in Drupal\Core\Asset\LibraryDependencyResolver->doGetDependencies() (line 53 of core\lib\Drupal\Core\Asset\LibraryDependencyResolver.php).

tamsoftware’s picture

tamsoftware CreditAttribution: tamsoftware commented

Hi yuriseki,

Thank you very much for your review!

Duplication: the main difference between my module at versions 1 and the SumoMe Integration module is that mine is for Drupal 8. I am under the impression that that module is abandoned (no commits for the past two years, no security review, no D8 version). I have contacted the author to offer a merge and am awaiting his answer. Version 2 will have additional controls such as pages not to display it on (such as /admin) and potentially users as well.

Drupal API: You are absolutely correct, thank you! - I followed documentation which I now need to find and have updated.

Comments: OF course it doesn't do that on mine. I am going to try on a fresh D8 install to see if I can reproduce. On yours does it show the script in the head at all? If it can be reproduced then please do add it as an issue.

Thanks again!

tamsoftware’s picture

tamsoftware CreditAttribution: tamsoftware commented

I have now been able to reproduce the bug and am adding it as an issue. Thanks!

I am also in contact with carsonblack who has agreed to have the two modules merge.

Thanks!

PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.