Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I'm submitting my module so its security can be peer reviewed.
Module name : Hide Preview Button
Module URL : https://www.drupal.org/project/hide_preview/
Repository :
git clone --branch 8.x-1.x https://git.drupal.org/project/hide_preview.git
Description
This module aims to finely tune the form Preview button visibility. There is only one settings form that allows to enter a list of patterns that will be used to check whether the form should display the Preview button or not.
Then on the hook_form_alter() it checks if the pattern matches the current form_id.
This was mainly intended to be used with the new contact form provided by default by D8.
Thanks for your help.
tim
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | errors.png | 28.3 KB | SergDidenko |
Comments
Comment #2
yseki CreditAttribution: yseki as a volunteer and commentedHi timothee.moulin,
There are some issues with your application:
1. Include the [D8] at the beginning of the issue title to allow reviewers to know that it's a D8 module.
2. Add the GIT command to clone your repository. You can find this command in your project page clicking on version control task, unchecking the Mantainer checkbox and clicking on Show button
3. The task category is also wrong. You need to update it to Task
Take a look at Apply for permission to opt into security advisory coverage, follow all the instruction, and give a special attention on step #5.
Comment #3
PA robot CreditAttribution: PA robot commentedGit clone command for the sandbox is missing in the issue summary, please add it.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #4
timothee.moulin CreditAttribution: timothee.moulin commentedComment #5
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojecthide_previewgit
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #6
timothee.moulin CreditAttribution: timothee.moulin commentedSome work has been done on the project to remove all errors reported by pareview.sh
Comment #7
logan.H CreditAttribution: logan.H commentedHi, Hope the following code dose not need to be inside the foreach ?, its not using anything from the array.
elseif (strpos($form_id, 'contact_message_') !== FALSE) {
$form['actions']['preview']['#access'] = FALSE;
}
Comment #8
SergDidenko CreditAttribution: SergDidenko commentedHi.
Please find results of manual review below:
1. I have gotten an error. The reason of it is incorrect using of configuration settings. So config variable is empty inside HidePreviewConfigForm.php and hide_preview.module. More detailes about defining and using your own configuration you can read here.
2. Inside hide_preview.module you should use \Drupal instead Drupal.
3. Inside HidePreviewConfigForm.php on line 39 displace the text from description to separate html.twig template and use there ul, li, i html tags.
Comment #9
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.