Convert system functional tests to phpunit

Scope:
./Routing/RouterTest.php

Postponed/needs followup:
./Routing/MockAliasManager.php
./Routing/MockRouteProvider.php

CommentFileSizeAuthor
#23 2982149-23.patch11.29 KBlendude
#18 2982149-18.patch25.92 KBvijaycs85
#18 2982149-diff-16-18.txt4.7 KBvijaycs85
#16 2982149-diff-9-16.txt8.56 KBvijaycs85
#16 2982149-16.patch24.55 KBvijaycs85
#9 page_routing_render_session_convert_functional_test-2982149-9.patch18.13 KBscuba_fly
#8 page_routing_render_session_convert_functional_test-2982149-8.patch68.46 KBscuba_fly
#7 page_routing_render_session_convert_functional_test-2982149-7.patch0 bytesscuba_fly
#4 page_routing_render_session_convert_functional_test-2982149-4.patch3.03 KBscuba_fly

Comments

Lendude created an issue. See original summary.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Parent issue: » #2862508: Convert system functional tests to phpunit
scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
commented
Assigned: Unassigned » scuba_fly

Converting this, moving the old tests to the new location and extending the right class.

Will create new issues for the failed test.

scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
commented
StatusFileSize
new page_routing_render_session_convert_functional_test-2982149-4.patch3.03 KB

Moved most of the files, changed namespace and converted to browserTestBase.
Still failing tests, but it is a good starting point to work on those tests.

I did not touch the files below, these are not tests. Lets figure this out later.
./Path/UrlAliasFixtures.php
./Routing/MockAliasManager.php
./Routing/MockRouteProvider.php

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: page_routing_render_session_convert_functional_test-2982149-4.patch, failed testing. View results

scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
commented
Issue tags: +DevDaysLisbon
StatusFileSize
new page_routing_render_session_convert_functional_test-2982149-7.patch0 bytes

New patch, with my work for now. Will continue working on this.

Added more files.
fixed tests for:
- DefaultMetatagsTest
- PagerTest

scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
commented
StatusFileSize
new page_routing_render_session_convert_functional_test-2982149-8.patch68.46 KB

wrong patch.

scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
commented
StatusFileSize
new page_routing_render_session_convert_functional_test-2982149-9.patch18.13 KB

Ok I need a break, this is the right patch with the work for now.

scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
commented
Issue summary: View changes
scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: page_routing_render_session_convert_functional_test-2982149-9.patch, failed testing. View results

scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
commented
Issue summary: View changes
scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
commented
Issue summary: View changes

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Needs review
StatusFileSize
new 2982149-16.patch24.55 KB
new 2982149-diff-9-16.txt8.56 KB

Here is an update.

Status: Needs review » Needs work

The last submitted patch, 16: 2982149-16.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Needs review
StatusFileSize
new 2982149-diff-16-18.txt4.7 KB
new 2982149-18.patch25.92 KB

Status: Needs review » Needs work

The last submitted patch, 18: 2982149-18.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented

splitting the session part into #3002121: Session: Convert system functional tests to phpunit this is getting too big to oversee.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Title: Page/Routing/Render/Session: Convert system functional tests to phpunit » Path/Routing: Convert system functional tests to phpunit
Issue summary: View changes
lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Issue summary: View changes
lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs work » Needs review
StatusFileSize
new 2982149-23.patch11.29 KB

So this now only covers the remaining routing tests.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Issue summary: View changes

Updated the scope in the IS.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Title: Path/Routing: Convert system functional tests to phpunit » Routing: Convert system functional tests to phpunit
lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented 
+++ b/core/modules/system/tests/src/Functional/Routing/RouterTest.php
@@ -311,21 +316,18 @@ public function testLeadingSlashes() {
-    $this->assertEqual(1, $this->redirectCount, $url . " redirected to " . $this->url);
...
-    $this->assertEqual(1, $this->redirectCount, $url . " redirected to " . $this->url);
...
-    $this->assertEqual(1, $this->redirectCount, $url . " redirected to " . $this->url);

$this->redirectCount is not a thing in BTB, so took those out. Also, the relevant coverage here is that the leading slashes are striped which the assertUrl() covers.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Assigned: scuba_fly » Unassigned
Status: Needs review » Reviewed & tested by the community

This is straightforward.

Alas, they are not a thing anymore BTB the heartbreaker. ;-P

  • larowlan committed 6e29b51 on 8.6.x 
    Issue #2982149 by scuba_fly, vijaycs85, Lendude: Routing: Convert system...

  • larowlan committed 3f77e72 on 8.7.x 
    Issue #2982149 by scuba_fly, vijaycs85, Lendude: Routing: Convert system...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 8.7.x-dev » 8.6.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 3f77e72 and pushed to 8.7.x. Thanks!
C/p as 6e29b513a2 and pushed to 8.6.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.