Needs work
Project:
Drupal core
Version:
main
Component:
views.module
Priority:
Normal
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
8 Jun 2018 at 19:44 UTC
Updated:
20 Jun 2023 at 10:35 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
pieterjanput commentedI've changed the help of this element. It's either this, or adding iframe as an allowed value to
$adminTagswhich probably has a lot more consequences.Comment #3
sudheeshps commentedApplied patch from #2 and was successful
Comment #4
cilefen commentedI think either "except for" or "not including" would be more widely understandable as more common phrasing than "save for".
Comment #5
lauriiiThank you for reviewing this issue!
The automated testing infrastructure tells us whether the patch applies, so we do not need people to review that. It is also not sufficient criteria for the issue to be marked "Reviewed and Tested by the Community".
What we do need people to review is whether the issue has a correct scope, whether it passes the core gates, whether the solution completely fixes the problem without introducing other problems, and whether it's the best solution we can come up with. See the patch review guide for more information.
When you do post a review, be sure to describe what you reviewed and how. This helps other reviewers understand why you considered the issue RTBC (and is considered for issue credit).
Based on #4, setting back to needs work.
Comment #6
sudheeshps commentedComment #7
sudheeshps commented@cilefen & @lauriii, thanks for the updates.
"not including" fits correctly here, so updating the same.
Added the updated patch for the same.
Please review and let me know
Comment #8
ipwa commentedThe same issue happens on the text area for rewrite field, iframes get stripped.
Comment #9
borisson_Setting to RTBC for #7, this correctly resolves the remark by @cilefen
Comment #10
mrweiner commentedGuess I should have included a patch initially for the help text, but wasn't sure if iframe embeds should actually be handled. Thanks y'all.
@ipwa the "rewrite field" issue you're describing should be probably exist in another issue so that it doesn't get lost/can be discussed appropriately.
Comment #11
mrweiner commentedSo, now that I actually read the patch -- does "scripts and styles" actually cover iframes? Which category do they fall under? If I saw the patch help text I think I'd still assume that an iframe should work, especially if I were a site builder.
Comment #13
m.roma commentedThis is also an issue in Drupal 7 - and I created an issue for that.
Comment #16
amerie commentedIf you need the ability to put an iframe in a view header, here is a custom area plugin we used to do that.
Comment #17
lendudeThis help text should probably be modelled after the fix in #2654962: Views content rewrite text says "You may include HTML" but actually allows only a subset, the same filtering applies here (without the Twig mention).
Comment #20
thomasmurphy commentedIt would be good if there was documentation around what attributes are stripped by what function, and whether this is configurable.
There is a more limited and achievable issue here just around style attributes
https://www.drupal.org/project/drupal/issues/3109650
Comment #26
damienmckenna