Problem/Motivation

Creating a table with $schema['primary key'] = []; is broken on PostgreSQL.

Proposed resolution

Fix it!

This requires #2881522: Add a Schema::findPrimaryKeyColumns method to remove database specific logic from test for test coverage.

CommentFileSizeAuthor
#6 2976493-6.patch2.29 KBtstoeckler
#6 2976493-6--tests-only.patch1.52 KBtstoeckler
#2 2976493-2--for-robots.patch12.28 KBtstoeckler
#2 2976493-2--tests-only.patch11.79 KBtstoeckler
#2 2976493-2--for-humans.patch2.32 KBtstoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented
Status: Active » Needs review
FileSize
2976493-2--for-humans.patch2.32 KB
2976493-2--tests-only.patch11.79 KB
2976493-2--for-robots.patch12.28 KB

Here we go.

daffie’s picture

daffie CreditAttribution: daffie commented
Title: [PP-1] Creating a table with an explicitly empty primary key is broken on PostgreSQL » Creating a table with an explicitly empty primary key is broken on PostgreSQL

#2881522: Add a Schema::findPrimaryKeyColumns method to remove database specific logic from test has landed. Started the testbot for the for humans patch.

The last submitted patch, 2: 2976493-2--for-humans.patch, failed testing. View results

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
2976493-6--tests-only.patch1.52 KB
2976493-6.patch2.29 KB

Here we go. Instead of actually rebasing, I just recreated the patch from scratch as it is so small, thus no interdiff for the test changes due to findPrimaryKeyColumns() now being protected.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.
The test only patch show that there is a bug and the full patch fixes that bug.
The code for this patch comes from is parent issue: #2881522: Add a Schema::findPrimaryKeyColumns method to remove database specific logic from test
For me it is RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

Crediting @daffie for reviewing the issue.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed c4923ea and pushed to 8.6.x. Thanks!

  • alexpott committed c4923ea on 8.6.x 
    Issue #2976493 by tstoeckler, daffie: Creating a table with an...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.