After adding, deleting or editing a menu item, I am redirected to the Menus Management page rather than returned to the Menu Edit page

Same problem

This is a very irritating way that the menu works.

This is indeed annoying, working on a fix

This adds the fix and a test

Ah, so linkByHrefExists is actual 'link containing href exists' so adding another assert that the destination isn't there.

#12 works!

We still need a failing test here

I have tested patch #17 . Applied successfully and working as per functionality. Attaching screenshots for reference

Before applying patch

After applying patch

+++ b/core/modules/menu_ui/tests/src/Functional/MenuUiTest.php
@@ -231,6 +231,9 @@ public function addCustomMenu() {
+    $url = Menu::load($menu_name)->toUrl('edit-form');
+    $this->assertSession()->linkByHrefExists($url->toString());
+    $this->assertSession()->linkByHrefNotExists($url->setOption('query', ['destination' => '/admin/structure/menu'])->toString());

Not sure if $this->assertSession() needs instantiation twice.

Maybe changed

+    $this->assertSession()->linkByHrefExists($url->toString());
+    $this->assertSession()->linkByHrefNotExists($url->setOption('query', ['destination' => '/admin/structure/menu'])->toString());

to

$assertSession = $this->assertSession();
$assertSession->linkByHrefExists($url->toString());
$assertSession->linkByHrefNotExists($url->setOption('query', ['destination' => '/admin/structure/menu'])->toString());

This is a duplicate of #2957953: Editing menus user-experience has regressed - which is an early issue, has more explicit testing. I think we should merge the approaches. This was caused by #2767857: Add destination to edit, delete, enable, disable links in entity list builders which I've kind of always felt should have been rolled back.

I quite like the fix here as it removes the default redirection completely but it'd be great continue to work in #2957953: Editing menus user-experience has regressed and add more test coverage of deleting and editing a menu-link via the UI so we can be sure that everything behaves as we'd like.