PHP 7.2: Warning: count(): Parameter must be an array or an object that implements Countable n Drupal\views\Plugin\views\argument_validator\Entity->validateEntity()

I'm curious how it was possible that this value is empty in the first place? It feels like just adding some checks here might hide an underlying bug.

Once we do understand the underlying bug, maybe this patch is exactly though the right solution.

I fear some level of tests are needed here to resolve the issue.

I ran into this when testing an upgrade to PHP 7.2 as well. This is indeed a minor bug in the views argument validator for entities. This validator works by allowing you to validate that an argument provided is an entity of a specific type. Additionally, if the entity type you're validating has bundles, it allows you to validate that the passed in argument matches one of the bundles.

The problem occurs when you add the validator for an entity type that doesn't have bundles. In that case, the "bundles" form option is not used, and when the form is submitted, it has no value. But the submit handler still tries to set a value:

  /**
   * {@inheritdoc}
   */
  public function submitOptionsForm(&$form, FormStateInterface $form_state, &$options = []) {
    // Filter out unused options so we don't store giant unnecessary arrays.
    $options['bundles'] = array_filter($options['bundles']);
  }

In this case, $options['bundles'] is NULL (key does not exist), so array_filter also returns NULL, so it saves NULL for the option.

We can fix that submit callback so that it doesn't save a NULL value and instead saves an empty array. That will fix it for people that re-save the argument config form or create a new argument, but doesn't help existing argument plugin configs. For that we could write a database update hook, but that's seriously overkill IMO. We can just handle the NULL case gracefully.

The previous patch works, but we can combine is_array() and count() > 0 into just a simple !empty().

small fix to comment.

1. +++ b/core/modules/views/src/Plugin/views/argument_validator/Entity.php
   @@ -148,7 +148,15 @@ public function buildOptionsForm(&$form, FormStateInterface $form_state) {
   +    // entity type doens't support bundles, so the option may not be set.
   

   doesn't is spelled as doens't

2. +++ b/core/modules/views/src/Plugin/views/argument_validator/Entity.php
   @@ -148,7 +148,15 @@ public function buildOptionsForm(&$form, FormStateInterface $form_state) {
   +    if (array_key_exists('bundles', $options)) {
   

   array_key_exists() can have a null value.

   $ php -r '$a["test"] = NULL; var_dump(array_key_exists("test", $a));'
   bool(true)

   Consider !empty($options['bundles']) because it's faster than array_key_exists(), but maybe cleaner just to cast it to an (array)?

Addressed feedback

All feedback addressed.

We must be missing test coverage as we run nightly tests on PHP 7.2 (and 7.3 now). Given this is now causing warnings we need to add that test coverage here. As per @dawehner / #6.

Attached is a patch against 8.8.x, which extends the existing unit test for the argument validator to cover this issue. No interdiff, since it's trivial.

Test results as expected on PHP7.2. The test fail in PHP 7.1 looks suspiciously like another random unrelated test fail in ManageGitIgnoreTest, so let's try again.

Retest came back green, filed #3070853: Race condition during composer cache clear in functional composer scaffolding plugin tests for the test fail.

Looks good

The test fail was most likely caused by #3085697-31: Allow scaffold plugin to append to non-scaffolded files. Retest came back green. Setting back to RTBC per #19.

Patch for Drupal 8.8 with PHP 7.3 doesn't work.

Random test fail, retest was green, back to RTBC per #19

Committed and pushed 73b8d10170 to 9.0.x and 9ade85c270 to 8.9.x and 74a79f60aa to 8.8.x. Thanks!

Backported to 8.8.x as a low risk bugfix.

Closed #2834801: Schema validation fails on the "entity" argument_validator when the "bundles" form key is not set as a duplicate, adding credit and tagging.