We need to replace the REQUEST_TIME which is deprecated with the core service.

CommentFileSizeAuthor
#7 autologout-fixed_request_time-2966369-7.patch6.83 KBi-trokhanenko
#3 2966369.png153.45 KBlomasr
#2 autologout_deprecated_request_time_2966369_2.patch2.72 KBnkoporec

Comments

nkoporec created an issue. See original summary.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Assigned: nkoporec » Unassigned
Status: Active » Needs review
StatusFileSize
new autologout_deprecated_request_time_2966369_2.patch2.72 KB
lomasr’s picture

lomasr commented
StatusFileSize
new 2966369.png153.45 KB

Applied the patch to worked cleanly for me. After applying the patch, I enabled the module no error showed up.

lomasr’s picture

lomasr commented
Status: Needs review » Reviewed & tested by the community
ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented
Status: Reviewed & tested by the community » Needs work

Thank you for reporting and the patch! There are some issues around dependency injection which needs to be addressed. Adding below:

  1. +++ b/src/AutologoutManager.php
@@ -120,7 +120,7 @@ class AutologoutManager implements AutologoutManagerInterface {
+    $time_passed = isset($_SESSION['autologout_last']) ? \Drupal::time()->getRequestTime() - $_SESSION['autologout_last'] : 0;

    Use of \Drupal:: should be avoided in places where the dependencies could be injected. 

  2. +++ b/src/Controller/AutologoutController.php
@@ -53,7 +53,7 @@ class AutologoutController extends ControllerBase {
+    $_SESSION['autologout_last'] = \Drupal::time()->getRequestTime();;

    Should be injected here as well. 

  3. +++ b/src/EventSubscriber/AutologoutSubscriber.php
@@ -51,7 +51,7 @@ class AutologoutSubscriber implements EventSubscriberInterface {
+    $now = \Drupal::time()->getRequestTime();

    And here.

ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented
Related issues: +#2966377: Dependency Injection issues

Adding related issue for reference.

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Needs work » Needs review
StatusFileSize
new autologout-fixed_request_time-2966369-7.patch6.83 KB

Used dependency injection. Please review!

bcizej’s picture

bcizej commented
Status: Needs review » Reviewed & tested by the community

Tested, works fine thanks.

bcizej’s picture

bcizej commented
Status: Reviewed & tested by the community » Closed (duplicate)
Related issues: +#3087011: Drupal 9 Deprecated Code Report for Automated Logout module

Solved in a ticket for D9.