There are some dependency injection issues in services and forms.Patch incoming,

CommentFileSizeAuthor
#9 interdiff-2966377-7-9.txt860 bytesyogeshmpawar
#9 2966377-9.patch12.77 KByogeshmpawar
#7 2966377-7.patch12.76 KByogeshmpawar
#2 autologout_di_2966377_2.patch13.04 KBnkoporec

Comments

nkoporec created an issue. See original summary.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Assigned: nkoporec » Unassigned
Status: Active » Needs review
StatusFileSize
new autologout_di_2966377_2.patch13.04 KB

Created a patch.Please reviewed it.

maaty388’s picture

maaty388 commented
Status: Needs review » Reviewed & tested by the community

Great!

ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented

Thank you for reporting, the patch, and the reviews! Looks like a great one!
However, it looks like the patch is no longer applicable. Let's see what the test results say.

ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Instructions on how to reroll - https://www.drupal.org/patch/reroll

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: Unassigned » yogeshmpawar
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: yogeshmpawar » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2966377-7.patch12.76 KB

Hi @AjitS, I have rerolled the patch #2.

Status: Needs review » Needs work

The last submitted patch, 7: 2966377-7.patch, failed testing. View results

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs work » Needs review
StatusFileSize
new 2966377-9.patch12.77 KB
new interdiff-2966377-7-9.txt860 bytes

Added updated patch for test failing & also added an interdiff for both patches

bcizej’s picture

bcizej commented
Status: Needs review » Closed (duplicate)
Related issues: +#3087011: Drupal 9 Deprecated Code Report for Automated Logout module

Solved in a patch for D9.