Sometimes we wanted to be able to allow some users to add other users,
but not change any user's password.

When the user profile form is loaded it checks to see if the current user
has the proper permission or if they are editing their own account,
otherwise, it removes the password change option.
There would be no point restricting the ability to change a user's password
if they can still change the user's e-mail address,
this option is removed as well.
This also removes the option to delete a user.

This module adds few new permissions:
* change other users password
* change own password
* reset password by request link
* change other users username
* change other users email
* delete other users
* block other users
(*) An image with permissions was included.

Project page:

https://www.drupal.org/project/restrict_password_change

Project Git Url:

git clone --branch 8.x-1.x https://git.drupal.org/project/restrict_password_change.git
cd restrict_password_change

To submit bug reports and feature suggestions, or to track changes:
https://drupal.org/project/issues/restrict_password_change

Installation and configuration:

Put the module in your Drupal modules directory and enable it in admin/modules.
Go to admin/people/permissions and grant permission to any roles that need.

PAReview Results:

https://pareview.sh/pareview/https-git.drupal.org-project-restrict_passw...

CommentFileSizeAuthor
Restricts_password_change_permissions.png176.85 KBheilop

Comments

heilop created an issue. See original summary.

avpaderno’s picture

Status: Active » Needs review
Issue tags: -Nashville2018
avpaderno’s picture

Priority: Normal » Critical

To the reviewers: Please set the priority to Normal after reviewing the project.

sleitner’s picture

Priority: Critical » Normal
Status: Needs review » Reviewed & tested by the community

Automated Review

Review of the 8.x-1.x branch (commit 05fa18e):

  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
no issues

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!

I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

heilop’s picture

Thank you guys, for your revisions.
Thanks, @kiamlaluno for you approve and recommendations.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.