Our legal department wants the cookie popup to show up on any new browser session. (I know.. I tried to talk them out of it...)

I set the cookie lifetime to 0 expecting to get a session cookie which would accomplish this. Instead, the cookie never gets set.

Attached to the next comment (need issue #) is a patch to the JavaScript that allows a setting of 0 to create a session cookie if you hide/agree.

Comments

cgmonroe created an issue. See original summary.

cgmonroe’s picture

Status: Active » Needs review
StatusFileSize
new805 bytes

Here's the patch to support session cookies.

edurenye’s picture

I think we must explain that behavior in the config page, and even better I think we should add the option to set 0 days as a valid value like it is now and add a checkbox to enable session cookie that when selected disables the session days input. What do you think?

edurenye’s picture

Status: Needs review » Needs work

At least change the description to explain how it works.

edurenye’s picture

Fixed adding it as checkbox.

svenryen’s picture

Thanks, I'll have a look once the GDPR features are finalized. If somebody does an RTBC I could commit it now :)

svenryen’s picture

Also, a port to D7 is welcome :)

mgifford’s picture

Issue tags: +GDPR
svenryen’s picture

@mgifford, why would you say this is related to GDPR?

svenryen’s picture

Issue tags: -GDPR
jan_mynarik’s picture

Hi, I've been told by legal counsel that this is needed for GDPR. Probably the opinion differs from lawyer to lawyer. I am waiting for this though :)

svenryen’s picture

Issue tags: +GDPR

I personally have a hard time agreeing with that. If a visitor to your site gave consent once that you can use their personal data and you offer a way to opt-out that's as easy to use as opting in was, (and you have some mechanism of storing the act of giving consent) you have actually fulfilled the requirements in GDPR.

I can see scenarios where your colleague, friend, or family member borrows your device, visits a site where you've previously consented, and boom, the site would now violate GDPR because somebody who's not consented is visiting, but I think that's stretching it a bit far.

Does anybody have an opinion of how prominent this feature should be in the UI? We now have 3 votes saying it's part of GDPR, so I guess my plan of hiding it way down under Advanced is out of the window? :)

jan_mynarik’s picture

@svenryen I am not personally sure if it is needed for GDPR but I should make that happen (agree every visit) because I was told so as part of the GDPR effort here.

mgifford’s picture

Logically I agree with you @svenryen it really shouldn't be something that is required each browser session. That said some countries and some lawyers may require it it seems.

svenryen’s picture

I have applied the patch, and tested it.

I rephrased the title and description for this option, since I'm not sure whether everybody would understand the meaning of 'Cookie session' as the checkbox label. I also added a reminder to double-check with the legal advisor, since this is a highly annoying feature when enabled. The consent storage mechanism may also be flooded if the site is very busy.

Here's the updated patch for d8. d7 patch to follow.

svenryen’s picture

Here's the patch for 7.x.

  • svenryen committed 0116b78 on 7.x-1.x
    Issue #2960487 by svenryen, edurenye, cgmonroe: Allow prompting for...

  • svenryen committed 48bf5ee on 8.x-1.x authored by edurenye
    Issue #2960487 by svenryen, edurenye, cgmonroe: Allow prompting for...
svenryen’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.