Closed (fixed)
Project:
Add To Calendar Button (AddEvent.com)
Version:
8.x-3.1
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
12 Apr 2018 at 07:03 UTC
Updated:
4 May 2021 at 19:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
guptahemant commentedhi @sumithb
Can you please add the screenshots of any issues produced on chrome console or any visible php errors, it would help to easily identify and resolve this error.
Thanks
Comment #3
naresh_bavaskarHi
I faced a similar issue on one of my ajax enabled views.
Issue description: addtocalendar.js was not calling after ajax request DOM element.
Attaching a patch to fix the issue.
Please review
Thanks
Comment #4
purushotam.rai commentedProbably we would need Drupal behaviors then.
Comment #5
naresh_bavaskarLast patch was wrong, thus added the correct patch. Kindly Review
Thanks
Comment #6
purushotam.rai commentedLGTM
Comment #8
guptahemant commentedhi @naresh_bavaskar
Thanks for explaining the issue, i was easily able to reproduce it and fix it via the provided patch. Marking this issue as done. keep contributing!
Comment #10
nightwalkr commentedHi, Added the ajaxSuccess() and validation but not repleat the "atcb-list" in the Add to Calendar.
Comment #11
aswathyajish commentedMe also had this issue. I was using the version 8.x-3.1.
Now I upgraded the module to the version 8.x-3.2. The patch has been committed to the version 8.x-3.2. And it is working now. Thanks a lot.
Comment #12
yoaHello,

In the versions that follow the commit of this issue,
I see multiple .atcb-lists added to each date instance: a list is added on every ajax load.
I checked the addtocalendar.js, and there is no check to whether there is already a list attached nor a logical marker to whether the list should be added or not.
Though this issue doesn't cause functional problems, it does cause accessibility problems with keyboard navigation or screenreaders.
I add here a pretty straight forward fix,
I'd be happy if someone with more JS experience can take a look at it or at this issue.
And as a side question - why did we create here a jQuery dependency?