Coding standards

Review of the 8.x-1.x branch (commit 486bdf3):

• Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
  • The INTRODUCTION section is missing.
  • The REQUIREMENTS section is missing.
  • The INSTALLATION section is missing.
  • The CONFIGURATION section is missing.
• The registration_link.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
• No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 137 characters
 7 | WARNING | Line exceeds 80 characters; contains 140 characters
--------------------------------------------------------------------------


FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/registration_link.module
--------------------------------------------------------------------------
FOUND 26 ERRORS AND 2 WARNINGS AFFECTING 12 LINES
--------------------------------------------------------------------------
  1 | ERROR   | [x] Missing file doc comment
  1 | ERROR   | [x] The PHP open tag must be followed by exactly one
    |         |     blank line
  2 | WARNING | [x] Unused use statement
  3 | WARNING | [x] Unused use statement
  5 | ERROR   | [x] Missing function doc comment
  5 | ERROR   | [ ] registration_link_uninstall() is an installation hook
    |         |     and must be declared in an install file
  5 | ERROR   | [x] Expected 1 space before opening brace; found 0
  6 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
  6 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
  6 | ERROR   | [x] Inline comments must start with a capital letter
  6 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
  7 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
  7 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
  8 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
  8 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
  8 | ERROR   | [x] Short array syntax must be used to define arrays
  9 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
  9 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
  9 | ERROR   | [x] Expected 1 space after FOREACH keyword; 0 found
  9 | ERROR   | [x] Expected 1 space after closing parenthesis; found 0
 10 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 10 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 10 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
 11 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 11 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 12 | ERROR   | [x] Spaces must be used to indent lines; tabs are not
    |         |     allowed
 12 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 13 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 27 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/registration_link.routing.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 8 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/registration_link.install
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | ERROR | [x] Missing file doc comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 449ms; Memory: 4Mb