In light of GDPR, we should offer to include a checkbox and link to the privacy policy on forms that collect personal information.

CommentFileSizeAuthor
#6 interdiff.txt654 bytesdinesh18
#6 2954017-6.patch6.69 KBdinesh18
#4 eu_test.tgz1017 bytesbucefal91
#4 2954017-personal-data-forms-4.patch6.7 KBbucefal91

Comments

svenryen created an issue. See original summary.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue tags: +GDPR
mgifford’s picture

mgifford
he/him
Primary language English
commented
Parent issue: » #2971868: Consent (Recital 32)

Adding parent reference for general issue.

bucefal91’s picture

bucefal91 commented
Status: Active » Needs review
StatusFileSize
new 2954017-personal-data-forms-4.patch6.7 KB
new eu_test.tgz1017 bytes

hello!

I'd propose to add it as an interface with an accompanying trait. So external developers would implement the interface whenever their form collects personal data. I believe that way it should be developer-friendly. I am attaching a patch that takes this approach + a tar.gz of a dummy module where I demonstrate how an external developer would use it. Install that module and navigate to "/eu-cookie-compliance-test/form" to see it in action.

svenryen’s picture

svenryen commented
Status: Needs review » Needs work

It looks really good, but needs a port to 7.x before it can be added to the module.

+++ b/src/PersonalInformationFormTrait.php
@@ -0,0 +1,133 @@
+    return $this->t('Check here to give you explicit agreement to collect personal data. More info can be found <a href="@url">here</a>,', [

I think we need to check with a native English speaker on this string. The grammar sounds a bit off. Maybe this would be better: "I accept processing of my personal data. For more information, read the [privacy policy]".

dinesh18’s picture

dinesh18 commented
Status: Needs work » Needs review
StatusFileSize
new 2954017-6.patch6.69 KB
new interdiff.txt654 bytes

Here is the updated patch and interdiff as per the comment #5

svenryen’s picture

svenryen commented

Thanks, now we just need a 7.x version and we can review and commit :)

svenryen’s picture

svenryen commented
Status: Needs review » Needs work

  • Dinesh18 authored 44b194b on 8.x-1.x 
    Issue #2954017 by bucefal91, Dinesh18, svenryen, mgifford: Display...
svenryen’s picture

svenryen commented
Status: Needs work » Fixed

Bet you didn't expect this :)
I tested the patch, and since no longer need D7 ports for new features, I committed the changes.

Thanks for helping improve the module!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.