Fix config schema for value_form component

Ok. After seeing my exported config, I see that it will be very hard to get this working quickly as the config structure depends on the field types.

My problems come from the keys in conditional_fields.settings (conditional_fields.schema.yml):
- value_form
- values
- and sometimes there is a key with the "controlled by" field name

As we are on short timing on a client project, and as we use conditional fields for only one field in the entire project, I will see if we can use the #states form API directly in custom code.

Hello Olga,

Thanks for your reply. Here is an update of the issue summary.

I will need to see the exact case on my current project but another case I found trying to reproduce:

• A content type with a "list (text)" (field_list_text) field and an entity reference field targeting nodes (field_content)
• Add a dependency:
  • target field: field_content
  • controlled by: field_list_text
  • visible when field_list_text has a certain value
• Result: when inspecting with the module config_inspector: in the entity form display, content.field_content.third_party_settings.conditional_fields.f75bfafe-e565-413b-a0c3-5bbca4d7bdf5.settings.value_form.0.value is undefined

Here is the entity form display:

uuid: 8fdfc8f1-64d1-4c42-a9e7-ac3322af9dd8
langcode: en
status: true
dependencies:
  config:
    - field.field.node.page.body
    - field.field.node.page.field_content
    - field.field.node.page.field_list_text
    - node.type.page
  module:
    - path
    - text
_core:
  default_config_hash: sb0qCkzU_8mNq29NehYAU8jCBXWPLeX0UN8sYFVGVcw
id: node.page.default
targetEntityType: node
bundle: page
mode: default
content:
  body:
    type: text_textarea_with_summary
    weight: 31
    region: content
    settings:
      rows: 9
      summary_rows: 3
      placeholder: ''
    third_party_settings: {  }
  created:
    type: datetime_timestamp
    weight: 10
    region: content
    settings: {  }
    third_party_settings: {  }
  field_content:
    weight: 121
    settings:
      match_operator: CONTAINS
      size: 60
      placeholder: ''
    third_party_settings:
      conditional_fields:
        f75bfafe-e565-413b-a0c3-5bbca4d7bdf5:
          dependee: field_list_text
          settings:
            state: visible
            condition: value
            grouping: AND
            values_set: 1
            value: ''
            values: {  }
            value_form:
              -
                value: test1
            effect: show
            effect_options: {  }
            selector: ''
          entity_type: node
          bundle: page
    type: entity_reference_autocomplete
    region: content
  field_list_text:
    weight: 122
    settings: {  }
    third_party_settings: {  }
    type: options_select
    region: content
  path:
    type: path
    weight: 30
    region: content
    settings: {  }
    third_party_settings: {  }
  promote:
    type: boolean_checkbox
    settings:
      display_label: true
    weight: 15
    region: content
    third_party_settings: {  }
  status:
    type: boolean_checkbox
    settings:
      display_label: true
    weight: 120
    region: content
    third_party_settings: {  }
  sticky:
    type: boolean_checkbox
    settings:
      display_label: true
    weight: 16
    region: content
    third_party_settings: {  }
  title:
    type: string_textfield
    weight: -5
    region: content
    settings:
      size: 60
      placeholder: ''
    third_party_settings: {  }
  uid:
    type: entity_reference_autocomplete
    weight: 5
    region: content
    settings:
      match_operator: CONTAINS
      size: 60
      placeholder: ''
    third_party_settings: {  }
hidden: {  }

Hi,

Sorry for the reply delay and sorry that after comment 4, I didn't have more time to help on this issue.

First thanks to have merged and to have it fixed!

I'm not sure it'll kick in after the issue is closed/fixed.

It will, and it has :). Yep, as a maintainer you have the options in the "credit & committing" fieldset and it is the last comment of a maintainer that takes precedence to give credits.

What I realized is that this fieldset default credit values is mainly based on patches uploaded. I know that it creates an additional step, but what I do on my projects before commiting, is to review the comments to have proper credit attribution because some comments may be useful even without code contribution. And in case of doubt I prefer to give credit.

Best regards,