Hello,
It seems that with the recent 8.x-4.1-rc1 update, the timestamp is using GMT hour whatever the website timezone setting is.
For example, here in Paris, France, today's backup at 10:08:03 CET with 'Ymd-His' timestamp has been labelled 20180223-090803.
Thanks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

PhilY created an issue. See original summary.

PhilY’s picture

Issue summary: View changes
bryrock’s picture

Version: 8.x-4.0-rc1 » 8.x-4.x-dev
Assigned: Unassigned » bryrock

I will add a patch for this momentarily.

bryrock’s picture

bryrock’s picture

Assigned: bryrock » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: Issue #2947219_#3_Make_timestamp_use_local_time.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

bryrock’s picture

Status: Needs work » Needs review

The patch passes when tested with the correct test (the default test for this module is set to unsupported PHP version for Drupal 8).

The module is using php function "gmdate" which always results in greenwich time. According to php manual, "Identical to the date() function except that the time returned is Greenwich Mean Time (GMT)."

The only change needed to get the timestamp to run on local time is:

- $name .= '-' . gmdate($this->confGet('timestamp_format'));
+ $name .= '-' . date($this->confGet('timestamp_format'));

In other words, change gmdate() to date(). That's it.

(It also works)

Alex Andrascu’s picture

Status: Needs review » Reviewed & tested by the community
DamienMcKenna’s picture

DamienMcKenna’s picture

Status: Reviewed & tested by the community » Fixed

Committed. Thanks.

  • DamienMcKenna committed f190311 on 8.x-4.x authored by bryrock
    Issue #2947219 by bryrock, PhilY, Alex Andrascu: Timestamp no more uses...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

PhilY’s picture

Having been away for a while, I just want to thank you for fixing: it works!