In #2822382: Make every $modules property protected on classes extending BrowserTestBase and KernelTestBase a number of tests were found that lie in BTB, but use WTB inheritance. Let's fix this.

Out of scope:

CommentFileSizeAuthor
#8 2946425-8.patch966 bytesAnonymous (not verified)
#6 out_of_scope.txt3.65 KBAnonymous (not verified)
#6 2946425-6.patch3.74 KBAnonymous (not verified)
#4 2946425-4.patch7.39 KBAnonymous (not verified)
#4 interdiff-2-4.txt1.04 KBAnonymous (not verified)
#2 2946425-2.patch7.46 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

vaplas created an issue. See original summary.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Active » Needs review
FileSize
2946425-2.patch7.46 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Needs work 
+++ b/core/modules/rdf/tests/src/Functional/NodeAttributesTest.php
@@ -2,7 +2,8 @@
+use Drupal\Tests\node\Functional\NodeTestBase;
+

Unneeded blank line added.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs work » Needs review
FileSize
interdiff-2-4.txt1.04 KB
2946425-4.patch7.39 KB

@borisson_, thanks for review! Done.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at Dx Experts commented
Issue tags: +phpunit initiative

Seems to overlap with #2948073: ContentTranslationUITestBase stragglers and #2864035: Convert web tests to browser tests for rdf module

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Issue summary: View changes
Related issues: +#2948073: ContentTranslationUITestBase stragglers, +#2946419: Entity: Convert system functional tests to phpunit, +#2864035: Convert web tests to browser tests for rdf module
FileSize
2946425-6.patch3.74 KB
out_of_scope.txt3.65 KB

#5: fair points, added info about them to the IS.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

Thank you for splitting out the unnecessary changes

+++ b/core/modules/node/tests/src/Functional/NodeTranslationUITest.php
@@ -442,12 +443,12 @@ protected function doTestTranslationEdit() {
-        $title = t('<em>Edit @type</em> @title [%language translation]', [
+        $title = new FormattableMarkup('<em>Edit @type</em> @title [%language translation]', [

Ideally we wouldn't touch this line. This is nothing here we need to worry about.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
FileSize
2946425-8.patch966 bytes

@dawehner, thanks for review! You are right, after splitting this issue lost some of the tests, which extends FileFieldTestBase.

NodeTranslationUITest is really unnecessary change (it was due to #2948700: Casting $text value to string in responseContains/responseNotContains methods).

Only one test remains ContentTranslationLanguageChangeTest. Perhaps, it can also be moved to #2948073: ContentTranslationUITestBase stragglers.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed a485956282 to 8.6.x and e644f945a2 to 8.5.x. Thanks!

As a test-only fix backported to 8.5.x

  • alexpott committed a485956 on 8.6.x 
    Issue #2946425 by vaplas, borisson_, Lendude, dawehner: Correcting the...

  • alexpott committed e644f94 on 8.5.x 
    Issue #2946425 by vaplas, borisson_, Lendude, dawehner: Correcting the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.