Entity: Convert system functional tests to phpunit

@vaplas uhh just wondering why this went from being the 'module' conversion to being the 'entity' conversion? And why the patch number uses the issue number for #2946425: Correcting the tests that lie in BTB but using WTB, doing too many things at the same time again? :)

This looks great for the entity conversion. Nice and clean. One thing:

+++ b/core/tests/Drupal/Tests/Listeners/DeprecationListenerTrait.php
@@ -189,6 +189,8 @@ public static function getSkippedDeprecations() {
+      'Drupal\system\Tests\Entity\EntityDefinitionTestTrait is deprecated in Drupal 8.5.0 and will be removed before Drupal 9.0.0. Instead, use \Drupal\Tests\system\Functional\Entity\Traits\EntityDefinitionTestTrait. See https://www.drupal.org/node/2946549.',
+      'Drupal\system\Tests\Entity\EntityWithUriCacheTagsTestBas is deprecated in Drupal 8.5.0 and will be removed before Drupal 9.0.0. Instead, use \Drupal\Tests\system\Functional\Entity\EntityWithUriCacheTagsTestBas. See https://www.drupal.org/node/2946549.',

We should never add new deprecations to this, just take them out. Are there any uses of this left in core after this conversion? If so, why? If not, there is no reason to add them, plus there is a typo in the last one, so it won't work anyway :).

Patch looks good to me , thanks for the patch.

Lets postpone on #2949363: Impossible to make trigger_error in some files without test fails, because deprecating the trait is the right thing to do and we really don't want to add to that list of suppressed deprecation warnings.

EntityDefinitionTestTrait is loaded during test discovery. Since @trigger_error() is in the file, it is not triggered when the trait is used, only when the file is loaded.

So this means that if any test discovery system scans the file system in that directory, it's going to end up triggering the error if it requires, includes or uses reflection on that trait.

There is the Traits directory, but since we're trying to deprecate a trait in-place, that won't work. Traits in the Traits directory can be autoloaded, but won't scanned for tests. You can see an example of this in simpletest module: http://cgit.drupalcode.org/drupal/tree/core/modules/simpletest/tests/src

This is also a bit of an argument in favor of #2296635: Evaluate performance impact of limiting test discovery to *Test.php filename suffix since that would filter out files ending in Trait.php.

The solution here is to not @trigger_error(), and to file a followup to eventually add it. Add a @todo in the deprecated trait.

I can't see anything wrong with this patch, looks very good.

Diggit. :-) Pretty close...

+++ b/core/modules/system/src/Tests/Entity/EntityDefinitionTestTrait.php
@@ -5,8 +5,13 @@
+ * @deprecated in Drupal 8.5.x and will be removed before Drupal 9.0.0.
+ * Use \Drupal\Tests\system\Functional\Entity\Traits\EntityDefinitionTestTrait.

+++ b/core/modules/system/src/Tests/Entity/EntityWithUriCacheTagsTestBase.php
@@ -7,8 +7,13 @@
+ * @deprecated in Drupal 8.5.x and will be removed before Drupal 9.0.0.
+ * Use \Drupal\Tests\system\Functional\Entity\EntityWithUriCacheTagsTestBase.

Add @see to the CR in these docblocks. Also, it's deprecated in 8.6.x now.

Adding 'needs IS update' because of this question from #8: "@vaplas uhh just wondering why this went from being the 'module' conversion to being the 'entity' conversion?"

Adding #2977105: Incomplete functional conversion for NodeCacheTagsTest as related. We might end up closing that one if this one gets all the things.

@Mile23 thanks for the review!

Updated the IS a bit, but the answer to #8 was in #9, it was a failed clone attempt :)

Updated the version numbers and added the needed @see's. Interdiff is a little weird, but that tends to happen with --find-copy patches.

LGTM.

I'm fairly sure this is blocking #2976889: Add a trait to create media types in tests and replace MediaFunctionalTestCreateMediaTypeTrait.

random fail

The random fail was in Drupal\Tests\media\FunctionalJavascript\MediaSourceFileTest, so not related to this testcode.

Committed 646584b and pushed to 8.6.x. Thanks!

Can we also get a follow-up to fix PHPUnit tests that extend \Drupal\system\Tests\Entity\EntityCacheTagsTestBase since that is also WTB. This is the problem with run-tests.sh it's far too clever for its own boots automatically determining test types using reflection.

The follow-up was already related: #2977105: Incomplete functional conversion for NodeCacheTagsTest

I just marked it closed because this issue fixed it.

A bit of a follow-up to show us where the problem lies: #2981678: Fail PHPUnit-based tests which still inherit from WTB/TB.