Closed (fixed)
Project:
Drupal core
Version:
8.5.x-dev
Component:
content_translation.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Feb 2018 at 18:01 UTC
Updated:
3 Apr 2018 at 11:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alexpottWhoops.
Comment #3
dawehnerrun-tests.sh--Comment #4
Anonymous (not verified) commentedThis is strange, but these tests fail locally for me with:
That's what it took to pass. I don't know why.
Comment #5
Anonymous (not verified) commentedComment #6
Anonymous (not verified) commentedWell, this is due to the fact that
WebAssert::responseContains()should take a string. ButAssertLegacyTrait::assertRaw()sends there the object in this case. Next fix also works.Comment #7
alexpottI think I prefer #5 as it makes conversions easier. Since you don't need to think about the object to string again. Can you re-upload that with an interdiff to #2? Thanks!
Comment #8
Anonymous (not verified) commentedPhpStrorm found 718 usages of AssertLegacyTrait::assertRaw (Ctrl+B by method). Many of them using
t()value. I tried to run some of them - and they also fail (but pass with fix from #6).But why this does not happen on DI?
Also in
Drupal\KernelTests\AssertContentTraitwe haveSo, maybe
(string) $rawwill give more compatibility betweenKernelTests\AssertContentTraitandFunctionalTests\AssertLegacyTrait?Comment #9
Anonymous (not verified) commented#7: Done.
Comment #10
alexpott@vaplas it does not happen for me locally either. It'd be good to understand why your set up is experiencing this problem. Since #2 passes locally for me and the testbot.
Comment #11
Anonymous (not verified) commentedThe problem in the latest version of the Mink. After https://github.com/minkphp/Mink/pull/743.
Current versioin:
$this->assert(stripos($actual, $text) !== false, $message);Edit:
needleparameter of thestrpos/stripos)Comment #12
alexpott@vaplas so I think we should back out your changes and file a separate issue about the changes to Mink and perhaps a PR against mink to fix unless this is a major version thing because they've changed their API.
Comment #13
Anonymous (not verified) commentedYep, sorry for noise about it here. Back to #3 RTBC.
Comment #14
Anonymous (not verified) commented#12.2 #2948700: Casting $text value to string in responseContains/responseNotContains methods.
So, please do not add credit to me here. The patch does not contain my work. My credit is waiting for me in #2948700 :)
Comment #15
alexpott@vaplas I think you do deserve credit on this issue. Credit is not just about whether you wrote lines in the patch. Your review and work discovered a problem that we have to address in another issue. Yes you'll get credit in that issue but your work here is valuable too.
Comment #16
catchCommitted/pushed to 8.6.x and cherry-picked to 8.5.x. Thanks!