Alias is not generated when Pathauto widget is hidden

There were various reports since 8.4 about strange effects. Only found time now to start looking into it. Can you check if #2945734: Fix automated test failures in 8.x-1.x is fixing this for you?

If not, a failing test would be helpful.

Any chance you can create a failing test that shows the scenario this fixes?

I had a similar problem using the Feeds module. I distilled it down to the following problem case where the path is not defined in a node. Here's a some code that fails when run in the Dev execute PhP page.

The odd thing is that the ksm call is required to make it fail.

$node = \Drupal::entityTypeManager()->getStorage('node')->create([
    'type' => 'basic_page',
    'title' => 'Test article',
    'langcode' => 'en', 
    'uid' => 1 
]);
ksm($node->path);
$node->save();

As the report says, pathauto does not generate the URL because $node->path->pathauto is NULL when the the updateEntityAlias method checks if the create flag has been set ( ~ line 306 ).

Seems like the "skip if pathauto processing is disabled" code should include a test if an entity is new and pathauto is NULL that allow the process to continue.

Those kind of problems are exactly what my changes in #2945734: Fix automated test failures in 8.x-1.x should solve. And they do, I verified that this test change is passing when combined with those changes.

However, I would prefer if it would be in \Drupal\Tests\pathauto\Kernel\PathautoKernelTest, possibly in an existing method. Can you do that as a test-only patch and a combined patch with my changes? Then we can commit that and I really think that most of the problems that people are reporting are fixed then.

+1 on Reviewed.

With this patch nodes with an pathauto pattern get created with the aliases and not /node/####.

As I suggested above, I moved the test to #2945734: Fix automated test failures in 8.x-1.x and committed it as part of that (with issue credit).

I do believe you that it doesn't fix your problem, but it would be great to have a test that actually covers that scenario. We could for example try to write an actual JS test that triggers an ajax operation (One option would be to do a file upload or maybe something as simple as a multi-value field with an add-another button?).

@cgmonroe: I would expect that your issue is resolved with the patch that I now committed.

FYI - Creating nodes via Feeds (or programatically) still fails after updating pathauto to the latest Dev. I still needed to patch the PathautoItem.isEmpty() method with the patch above.

I think part of this is Drupal core 8.4 vs 8.5. The testCreateNodeWhileAccessingPath is passing in the Drupal 8.5 test environment. However, if I run the test code in a Dev PhP window on my 8.4 site, it fails to create a node with an alias.

Anyway, attached is the same patch as #18 without the test which you have already committed. It applies cleanly to the new dev code.

#23 solves my issue of path aliases not being created on node creation with 8.x-1.1.

Never mind. This is no longer working. May be related to #2950701: Pathauto pattern is not applied on first node save.

Rerolled the patch since I had some issues applying the patch in #23.

@seanB: Do you have a use case where this is needed? We still don't have a failing tests on 8.4.5+ that needs this change.

@Berdir I will have to get back to you on that, was just fixing a build and was not involved in the decision to use this patch. My collegue is not working rest of the week so I'll let you know when I had the chance to talk to him!

I can confirm that as of pathauto 8.x-1.2 within Drupal 8.5.2, new content nodes created via the GUI still do not have a pathauto pattern applied if the "URL Alias" form element is disabled within that content type's form display settings.

(The correct pathauto pattern is applied after the second "save".)

I'm not sure how to go about creating a test, but I'm happy to provide whatever info I can.

In the meantime, the patch in #25 has fixed the issue. (Exposing the URL Alias widget is not a viable option for us.)

I can also confirm that as of pathauto 8.x-1.3 within Drupal 8.6.4, new nodes created via the GUI still do not have a pathauto pattern applied if the "URL Alias" form element is disabled within that content type's form display settings.

The pathauto pattern is only applied after a resave.

Can confirm patch #25 has fixed the issue.

Confirm the #25 patch still works applied to 1.4 on core 8.7.3.

Enabled testing on current patch.

#25 works with core 8.7.5 and Pathauto 1.4.0

Looks like the patch still needs failing tests that this patch can fix as per @Berdir in #2946273-26: Alias is not generated when Pathauto widget is hidden

Here's a test for this. Note that #2756703: URL Alias not saving in some cases does not fix this issue.

Thanks.

Any chance a Pathauto 8.x-1.5 release will ship soon? It would be great to have this in a stable release.