The range widget requires the jQuery-ui-Slider-Pips library. After including it via asset-packagist or downloading the latest release from the project's github page, the slider JS/CSS is still missing.

It looks like the library now splits its assets into src/ and dist/ directories, so the paths to the required JS and CSS files, defined in facets_range_widget.libraries.yml need to be updated.

CommentFileSizeAuthor
#5 update-facets-range-widget-library-paths-2943636-5.patch2 KBNickDickinsonWilde
#2 update-facets-range-widget-library-paths-2943636-2.patch900 bytesDevin Carlson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Devin Carlson created an issue. See original summary.

Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Status: Active » Needs review
FileSize
update-facets-range-widget-library-paths-2943636-2.patch900 bytes

A patch to update the library paths.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Looks solid.

bohart’s picture

bohart
Location Lutsk, Ukraine
CreditAttribution: bohart as a volunteer and at DevBranch, Drupal Ukraine Community commented
Status: Reviewed & tested by the community » Needs work

In that case, readme file should be updated as well:

http://cgit.drupalcode.org/facets/tree/modules/facets_range_widget/READM...

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented
Status: Needs work » Needs review
FileSize
update-facets-range-widget-library-paths-2943636-5.patch2 KB

Patch updated to include readme changes.
Note: this is now a breaking change since there has been a full release; probably needs a change record if it can be applied.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented

It does need a change notice, and an update in the demo-site: https://github.com/nickveenhof/drupal8-umami-search/issues/14

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented

Created a Change Record (draft) and PR for demo site.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Fixed

I agree that this is a good change. Thanks so much for ya'lls work here and for the PR to the demo site.

  • borisson_ committed ca701c6 on 8.x-1.x authored by NickWilde 
    Issue #2943636 by Devin Carlson, NickWilde: Update jquery.ui.slider.pips...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.