Because Storify is shutting down, this module provides a way to display social media embed code and external pages in a card-like format similar to Storify. It creates paragraph types and a content type that will display a list of the stories a user enters. The paragraphs and lists contain minimal styling so the user can style them to match their needs.
Project URL
https://www.drupal.org/project/news_cards
Git URL
git clone --branch 8.x-1.x https://git.drupal.org/project/news_cards.git
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | patch.txt | 365 bytes | norman.lol |
| #2 | news_cards-phpcs_coding_errors-2943337-1-D8.patch | 0 bytes | bharath-kondeti |
Comments
Comment #2
bharath-kondeti commentedIam uploading a patch file for the issue
Comment #3
norman.lol- Added Storify link
- Added project URL
- Fixed typo
Comment #4
norman.lolgulpfile.js
This module contains a gulpfile.js, a Sass file and npm package.json and lock file. I'm pretty sure as they are only needed for development that they should be removed from your module. Users who download your module are not supposed to make any use of such resources. They should instead override the styling from their own theme.
Module depencies (news_cards.info.yml)
I'm pretty sure you don't need that much dependencies or do you? Please review them thoroughly and remove then ones that ain't necessary for your module to work properly.
README.txt
Please fix your README along the guidelines.
Comment #5
norman.lolComment #6
blakemorgan commentedI am trying to apply patch #3, but it is empty.
Comment #7
blakemorgan commentedI have removed the dev files, extraneous dependencies, and updated the README as per #4.
Comment #8
blakemorgan commentedComment #9
norman.lolCode sniffer found only one missing newline in the info file. That's all.
Comment #10
ashish-deynap commentedAutomated Review
Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting.
(./css/paragraphs--stories.css.map: ASCII text, with very long lines, with no line terminators)Code sniffer found only one missing newline at the end of info file.
Manual Review
Comment #11
norman.lol@ashish – LICENSE.txt is not missing.
Comment #12
blakemorgan commentedCommitted fixes for #9 and #10.
Comment #13
blakemorgan commentedComment #14
sleitner commentedAutomated Review
Review of the 8.x-1.x branch (commit 1b981db):
This automated report was generated with PAReview.sh, your friendly project application review script.
Manual Review
The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #15
avpadernoThank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #16
avpadernoComment #17
avpaderno