Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
5 Feb 2018 at 13:08 UTC
Updated:
29 Aug 2018 at 11:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
norman.lolFollowing coding standard errors found. Please review.
Comment #3
norman.lolCreated a patch to fix most of them. Please review and apply.
Comment #4
norman.lolFollowing the checklist I found these issues:
- Fix README.txt along the README guidelines.
- Add
core =andpackage =to your module's info file following the info file guidelines.- Add proper code and function documentation in your module file (as also the patch only adds rough and empty docs).
Comment #5
norman.lolComment #6
gerson.analista commentedComment #7
gerson.analista commentedThanks for your review and development tips.
I applied your patch and made the changes to README.txt and .info file.
I commited changes to dev and created a new release tag 1.4 - https://www.drupal.org/project/block_class_tacac
Comment #8
gerson.analista commentedComment #9
gerson.analista commentedI applied some changes and commited them to dev and created a new release tag 1.5
Comment #10
gerson.analista commentedComment #11
norman.lolComment #12
sleitner commentedAutomated Review
Pareview details: https://pareview.sh/pareview/https-git.drupal.org-project-block_class_ta...
Review of the 7.x-1.x branch (commit d1f5b9a):
hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .This automated report was generated with PAReview.sh, your friendly project application review script.
Manual Review
The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #13
gerson.analista commentedThanks for the tips and contributions.
I applied the suggested fixes in the dev branch, could you check?
Comment #14
sleitner commentedREADME.txt, hook_help() and coding standards follow recommendations
Comment #15
avpadernoThank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #16
avpadernoComment #17
gerson.analista commentedThanks kiamlaluno!