Overview

This module creates a taxonomy vocabulary to store CSS Classes and use it for autocompleting on the Block Class module field.

Project Information

Project Page: https://www.drupal.org/project/block_class_tacac
Git clone: git clone --branch 7.x-1.x https://git.drupal.org/project/block_class_tacac.git

Comments

gerson.analista created an issue. See original summary.

norman.lol’s picture

StatusFileSize
new7.92 KB

Following coding standard errors found. Please review.

norman.lol’s picture

StatusFileSize
new7.25 KB

Created a patch to fix most of them. Please review and apply.

norman.lol’s picture

Following the checklist I found these issues:

- Fix README.txt along the README guidelines.
- Add core = and package = to your module's info file following the info file guidelines.
- Add proper code and function documentation in your module file (as also the patch only adds rough and empty docs).

norman.lol’s picture

Status: Needs review » Needs work
gerson.analista’s picture

gerson.analista’s picture

Thanks for your review and development tips.
I applied your patch and made the changes to README.txt and .info file.
I commited changes to dev and created a new release tag 1.4 - https://www.drupal.org/project/block_class_tacac

gerson.analista’s picture

Status: Needs work » Needs review
gerson.analista’s picture

I applied some changes and commited them to dev and created a new release tag 1.5

gerson.analista’s picture

Assigned: Unassigned » gerson.analista
Status: Needs review » Fixed
norman.lol’s picture

Assigned: gerson.analista » Unassigned
Priority: Normal » Critical
Status: Fixed » Needs review
sleitner’s picture

Priority: Critical » Normal
Status: Needs review » Needs work

Automated Review

Pareview details: https://pareview.sh/pareview/https-git.drupal.org-project-block_class_ta...

Review of the 7.x-1.x branch (commit d1f5b9a):

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template. See pareview
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
See pareview

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

gerson.analista’s picture

Status: Needs work » Needs review

Thanks for the tips and contributions.

I applied the suggested fixes in the dev branch, could you check?

sleitner’s picture

Status: Needs review » Reviewed & tested by the community

README.txt, hook_help() and coding standards follow recommendations

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!

I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

avpaderno’s picture

gerson.analista’s picture

Thanks kiamlaluno!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.