Follow-up to #2669074: Convert file_create_url() & file_url_transform_relative() to service, deprecate it

Problem/Motivation

The module contains few deprecated functions and constant

Proposed resolution

Remove deprecated functions and constant, also clean-up leftover mentions

Remaining tasks

review/commit

User interface changes

No

API changes

No

Data model changes

No

CommentFileSizeAuthor
#19 2940025-19.patch31.75 KBandypost
#19 interdiff.txt11.25 KBandypost
#13 2940025-13.patch32.43 KBandypost
#13 interdiff.txt874 bytesandypost
#12 2940025-12.patch31.81 KBandypost

Comments

nickolaj created an issue. See original summary.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

drumm’s picture

drumm
he/him
Location NY, US
commented

Re-publishing this issue. It was likely incorrectly identified as spam.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 9.4.x-dev » 10.0.x-dev
Issue tags: +Deprecation Removal
andypost’s picture

andypost
he/him
Primary language Russian
commented
Parent issue: #2229865: [meta] Modernize File/StreamWrapper API » #3213895: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 10 branch
Related issues: +#2229865: [meta] Modernize File/StreamWrapper API
andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Remove usages of deprecated function file_create_url() throughout core functions » Remove deprecated functions from file.module
Status: Active » Needs review
Related issues: +#3260766: Remove deprecated file.inc and its mentions
StatusFileSize
new 2940025-12.patch31.81 KB

Repurposing as commited #3260766: Remove deprecated file.inc and its mentions

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt874 bytes
new 2940025-13.patch32.43 KB

fix CS

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Drupal 10, +ContributionWeekend2022
quietone’s picture

quietone commented

The IS could use an update, this is removing code not 'replacing' as stated in the remaining tasks.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Remove deprecated functions from file.module » Remove deprecated functions from file module
Issue summary: View changes

Thanks, updated IS and title

daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs a reroll.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new interdiff.txt11.25 KB
new 2940025-19.patch31.75 KB

re-roll, I bet because of mime-guesser fixes

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Reroll looks good, back to RTBC.

  • catch committed 0a045ce on 10.0.x 
    Issue #2940025 by andypost, nickolaj, quietone: Remove deprecated...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Opened a rector issue at #3264321: Rules for file_save_data, file_copy and file_move

Committed 0a045ce and pushed to 10.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.