Changed to depend on fakeobjects module

Totally agree with you David!
CKEditor FakeObjects
I wish that FakeObjects and the Anchor Link comes with Drupal 8 Core CKEditor package.

Drupal.org Library Packaging Whitelist

#2940014: CKEditor Fake Objects

I had created the following issue 7 months ago
#2888309: CKEditor Anchor link

Starting a new branch 8.x-2.x to follow with the best practice

Hi @RajabNatshah,

we had the problem on many sites where we upgraded anchor_link that drupal/fakeobjects was missing but composer didn't tell. Later on we had errors in Drupal:

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "fakeobjects" plugin does not exist. Valid plugin IDs for Drupal\ckeditor\CKEditorPluginManager are: link, language, internal, drupalimage, drupalimagecaption, stylescombo, drupallink, drupalentity, drupalfontawesome, tokenbrowser in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (Zeile 53 in /web/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).

So I looked into the composer.json of anchor_link and saw that drupal/anchor link isn't listed there? Do you know why? Perhaps we should reopen the issue and ensure it's required?

Current 8.x-2.4:

{
  "name": "drupal/anchor_link",
  "description": "This plugin module adds the better link dialog and anchor related features to CKEditor in Drupal 8.",
  "type": "drupal-module",
  "homepage": "https://www.drupal.org/project/anchor_link",
  "license": "GPL-2.0-or-later",
  "minimum-stability": "dev",
  "authors": [
    {
      "name": "Vardot",
      "homepage": "https://www.drupal.org/vardot",
      "role": "Maintainer"
    }
  ],
  "support": {
    "issues": "https://www.drupal.org/project/issues/anchor_link",
    "source": "http://cgit.drupalcode.org/anchor_link"
  },
  "repositories": [
    {
      "type": "composer",
      "url": "https://packages.drupal.org/8"
    }
  ],
  "require": {},
  "extra": {
    "branch-alias": {
      "dev-8.x-2.x": "8.2.x-dev"
    }
  }
}

While it is in 8.x-2.x-dev.

I'm not sure how this could happen. Perhaps a build mistake from drupal.org? I guess we need a new 2.5 release?

I'm running into this same issue, and like Anybody have been hit with errors when attempting to edit/create nodes. So, for the moment, it may be good to at least have a patch ready, for users who aren't comfortable with running development versions of a module on the production environments.

@RajabNatshah could you perhaps have a look at #12 and reopen this eventually?

#3129944: Add Fakeojects requirement to composer.json

Thank you :)