IPE search JavaScript breaks when a block doesn't have a label [#2938252]

Steps to reproduce

- Create some kind of block without label, fx a content block.
- Create a panel
- Try to use the search
- Observe a javascript error breaks the search (TypeError: attribute is null)

Desired outcome

It's possible to search in the blocks that has a label

Proposed resolution

Fix the JavaScript error so search isn't broken if block models doesn't have the attribute defined that is being search for.

Comment	File	Size	Author
#10	2938252-10.patch	563 bytes	hchonov
#6	2938252-2.patch	539 bytes	MykolaVeryha
#4	2938252-2.patch	539 bytes	MykolaVeryha
#3	2938252-2.patch	539 bytes	MykolaVeryha
#2	2938252-1.patch	543 bytes	googletorp

Comments

Comment #1

20 January 2018 at 11:56

googletorp created an issue. See original summary.

Comment #2

googletorp commented 20 January 2018 at 11:59

Status:

Active

» Needs review

Status	File	Size
new	2938252-1.patch	543 bytes

I have created a super simple patch, which changes null values into an empty string, ensuring the search works. The JavaScript looks to be built in a way, where it would be possible to search for any attribute defined in the JS model.

As search could be searching any attributes, making the default value "no label" seems like a poor option. Also this ensures search never breaks, as we know we that attributes is always a string. For me it also makes a lot of sense that you can't search for models missing the attribute being searched for.