Steps to reproduce

- Create some kind of block without label, fx a content block.
- Create a panel
- Try to use the search
- Observe a javascript error breaks the search (TypeError: attribute is null)

Desired outcome

It's possible to search in the blocks that has a label

Proposed resolution

Fix the JavaScript error so search isn't broken if block models doesn't have the attribute defined that is being search for.

CommentFileSizeAuthor
#10 2938252-10.patch563 byteshchonov
#6 2938252-2.patch539 bytesMykolaVeryha
#4 2938252-2.patch539 bytesMykolaVeryha
#3 2938252-2.patch539 bytesMykolaVeryha
#2 2938252-1.patch543 bytesgoogletorp
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

googletorp created an issue. See original summary.

googletorp’s picture

googletorp CreditAttribution: googletorp as a volunteer and at Reveal IT commented
Status: Active » Needs review
FileSize
2938252-1.patch543 bytes

I have created a super simple patch, which changes null values into an empty string, ensuring the search works. The JavaScript looks to be built in a way, where it would be possible to search for any attribute defined in the JS model.

As search could be searching any attributes, making the default value "no label" seems like a poor option. Also this ensures search never breaks, as we know we that attributes is always a string. For me it also makes a lot of sense that you can't search for models missing the attribute being searched for.

MykolaVeryha’s picture

MykolaVeryha CreditAttribution: MykolaVeryha commented
FileSize
2938252-2.patch539 bytes
MykolaVeryha’s picture

MykolaVeryha CreditAttribution: MykolaVeryha commented
FileSize
2938252-2.patch539 bytes

Patch for 4.4

MykolaVeryha’s picture

MykolaVeryha CreditAttribution: MykolaVeryha commented

dfdf

MykolaVeryha’s picture

MykolaVeryha CreditAttribution: MykolaVeryha commented
FileSize
2938252-2.patch539 bytes

dfdf

MykolaVeryha’s picture

MykolaVeryha CreditAttribution: MykolaVeryha commented
berliner’s picture

berliner CreditAttribution: berliner commented
Status: Needs review » Reviewed & tested by the community

Patch in #2 applies properly and looks straight-forward enough to RTBC.

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Acquia commented
Status: Reviewed & tested by the community » Closed (outdated)
hchonov’s picture

hchonov
Primary language Bulgarian
Location 🇪🇺🇩🇪🇧🇬
CreditAttribution: hchonov at 1xINTERNET commented
Status: Closed (outdated) » Needs review
FileSize
2938252-10.patch563 bytes