Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
This is a spin-off of #2932035: ResourceTypes should be internal when EntityType::isInternal is TRUE
We want to let resource types "opt-out" of the API.
Proposed resolution
We can do this by adding an isInternal() method on ResourceTypes.
Remaining tasks
- DONE:
#2937961: ResourceType should provide related ResourceTypes - DONE:
#2939704: Add ResourceType::isInternal() - DONE: #2939705: Do not include internal resource types under `include`
- DONE: #2939722: Do not provide routes for internal resource types
- MINOR: #2939729: Do not provide links to related/relationship routes for internal resource types.
Comments
Comment #2
gabesulliceBroke this out into subtasks because the patch was becoming unreadable. They can be committed independently or in a final combined patch.
Upgraded the task to Major because that's more accurate.
Comment #3
wim leersCan we get a status update here? What remains to be done? What % is done?
Comment #4
e0ipsoTotally agree. Thanks for doing tha @gabesullice.
I believe this is the most important point of focus along with test coverate (and any bug uncovered by tests). Do you guys feel the same way?
Comment #5
gabesulliceI'd put it around 77.77778% finished.
isInternaland related resource types) are committed. That's 2/5ths of the meta-issue, but half the battle. [50% of effort/0.00000% remaining]These are just some rough estimates, so please don't quote me on it.
Comment #6
wim leers😂 Those are the most ridiculously over-the-top precise "rough estimates" I've ever seen, nice one :P
So, TL;DR = there are 3 issues left.
Comment #7
wim leers#2932035: ResourceTypes should be internal when EntityType::isInternal is TRUE just landed. #2939705: Do not include internal resource types under `include` and #2939722: Do not provide routes for internal resource types are close.
Comment #8
wim leers#2939705: Do not include internal resource types under `include` also landed. 🎉
Comment #9
wim leers#2939705: Do not include internal resource types under `include` was just re-committed, after it was reverted shortly after getting committed.
Comment #10
wim leers#2939722: Do not provide routes for internal resource types also landed! That only leaves #2939729: Do not provide links to related/relationship routes for internal resource types. :)
Comment #11
wim leers#2939729: Do not provide links to related/relationship routes for internal resource types. also landed, which means this is now DONE! 🎉🎉🎉
Comment #12
wim leers