As title. They should preferably be CSS only for easy customization. This can be implemented also using different templates for widgets. No images. See some examples of design:

Current design:

Screenshot

CommentFileSizeAuthor
#24 alternative-widget-designs-2933333-24.patch624 bytesid.rem.dev
#23 Welcome to Violet Violet (1).jpg8.04 KBlolandese
#23 Welcome to Violet Violet.jpg6.81 KBlolandese
#20 alternative-widget-designs-2933333-20.patch445 bytesstockticker
#15 alternative-widget-designs-2933333-15.patch928 bytesstockticker
#14 Screenshot from 2018-02-01 15-26-13.png4.26 KBknyshuk.vova
#11 alternative-widget-designs-2933333-11.patch2.53 KBstockticker
#7 interdiff.txt3.82 KBstockticker
#7 alternative-widget-designs-2933333-7.patch19.88 KBstockticker
#5 alternative-widget-designs-2933333.patch16.93 KBstockticker
#2 test2 Some fancy site name (1).jpg6.45 KBlolandese

Comments

lolandese created an issue. See original summary.

lolandese’s picture

lolandese commented
Issue summary: View changes
StatusFileSize
new test2 Some fancy site name (1).jpg6.45 KB
knyshuk.vova’s picture

knyshuk.vova commented
Issue summary: View changes
stockticker’s picture

stockticker commented
Assigned: Unassigned » stockticker
Issue tags: +LutskGSW18
stockticker’s picture

stockticker commented
Assigned: stockticker » Unassigned
Status: Active » Needs review
StatusFileSize
new alternative-widget-designs-2933333.patch16.93 KB

Added alternative designs for widget types, which can be chosen from widget_block block settings form.

knyshuk.vova’s picture

knyshuk.vova commented
Status: Needs review » Needs work

1. The patch is not applies.

error: cannot apply binary patch to 'images/icons/signal.png' without full index line
error: images/icons/signal.png: patch does not apply
alternative-widget-designs-2933333.patch:505: new blank line at EOF.

2. Use svg icon or font awesome (instead of png) for better styling (for example changing color)

stockticker’s picture

stockticker commented
Status: Needs work » Needs review
StatusFileSize
new alternative-widget-designs-2933333-7.patch19.88 KB
new interdiff.txt3.82 KB

Changed .png file to .svg and fixed error with index.

lolandese’s picture

lolandese commented
Status: Needs review » Needs work

Patch applies cleanly now.

Probably needs an upgrade path using the function hook_update_N. More info.

Now it gives for an existing block:

This block is broken or missing. You may be missing content or you might need to enable the original module.

Another error was fixed by clearing the site cache. As this always makes part of running update.php, this should not be a problem:

Uncaught PHP Exception Drupal\\Component\\Plugin\\Exception\\PluginException: "Plugin (uptime_widget_fancy_block) instance class "Drupal\\uptime_widget\\Plugin\\Block\\UptimeWidgetFancyBlock" does not exist." at /home/martin/www/violet/core/lib/Drupal/Component/Plugin/Factory/DefaultFactory.php line 97

lolandese’s picture

lolandese commented

Remove the patch file from the repo.

stockticker’s picture

stockticker commented
Status: Needs work » Needs review
StatusFileSize
new alternative-widget-designs-2933333-11.patch2.53 KB

Should be fixed now.

knyshuk.vova’s picture

knyshuk.vova commented

The patch fixes the error from #9

knyshuk.vova’s picture

knyshuk.vova commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot from 2018-02-01 15-26-13.png4.26 KB

The diamond widget style seems broken with ratio 99.99% . Needs additional work.
widget

stockticker’s picture

stockticker commented
Status: Needs work » Needs review
StatusFileSize
new alternative-widget-designs-2933333-15.patch928 bytes

Please review, now it should work correctly with different ratio length.

knyshuk.vova’s picture

knyshuk.vova commented

Looks better

knyshuk.vova’s picture

knyshuk.vova commented
Status: Needs review » Fixed
ApacheEx’s picture

ApacheEx commented
Status: Fixed » Needs work 
  1. +++ b/uptime_widget.install
@@ -68,3 +68,17 @@ function uptime_widget_update_8001() {
+      $config = \Drupal::configFactory()->getEditable($value);
+      $config->set('plugin', 'uptime_widget_block');

    I do not see $config->save() 

  2. +++ b/uptime_widget.install
@@ -68,3 +68,17 @@ function uptime_widget_update_8001() {
\ No newline at end of file

    Pls add a new blank line

stockticker’s picture

stockticker commented
Status: Needs work » Needs review
StatusFileSize
new alternative-widget-designs-2933333-20.patch445 bytes

knyshuk.vova’s picture

knyshuk.vova commented
Status: Needs review » Fixed

The patch fixes issues from #19

lolandese’s picture

lolandese commented
Status: Fixed » Needs work
StatusFileSize
new Welcome to Violet Violet.jpg6.81 KB
new Welcome to Violet Violet (1).jpg8.04 KB

Still not right in the default theme Bartik in the region Sidebar first for the Widget Types circle and diamond (see screenshots).

Circle Widget Type

Diamond Widget Type

id.rem.dev’s picture

id.rem.dev commented
Status: Needs work » Fixed
StatusFileSize
new alternative-widget-designs-2933333-24.patch624 bytes

Made small css changes to the diamond-styled widget.
Couldn`t reproduce the issue with circle widget. Tried Chrome 64, Chromium 64, Firefox 58.0.1, Opera 50.0: Bartik from D 8.6.x, 8.4.4.
Commit as it is now.
@lolandese, please provide additional info to reproduce and fix it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.